[dolphin] [Bug 477425] Crash in UpdateItemStatesThread::run

2024-03-24 Thread Méven
https://bugs.kde.org/show_bug.cgi?id=477425

Méven  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/syst
   ||em/dolphin/-/commit/d270700
   ||c0ef42b6f1e1bef09bbf0bab59b
   ||3e78d1
 Resolution|--- |FIXED

--- Comment #17 from Méven  ---
Git commit d270700c0ef42b6f1e1bef09bbf0bab59b3e78d1 by Méven Car.
Committed on 24/03/2024 at 10:55.
Pushed by meven into branch 'master'.

versioncontrol: Prevent a use-after-free in UpdateItemStatesThread

UpdateItemStatesThread kept a pointer reference to m_plugin whose
lifetime was tied to VersionControlObserver parents.
On application shutdown it could happen the thread is still running when
the Observer is destroyed.

Make the plugin pointer a weak reference, allowing to stop the thread
when the plugin is gone.

M  +8-4src/views/versioncontrol/updateitemstatesthread.cpp
M  +2-1src/views/versioncontrol/updateitemstatesthread.h

https://invent.kde.org/system/dolphin/-/commit/d270700c0ef42b6f1e1bef09bbf0bab59b3e78d1

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 477425] Crash in UpdateItemStatesThread::run

2024-03-22 Thread Daniele Scasciafratte
https://bugs.kde.org/show_bug.cgi?id=477425

Daniele Scasciafratte  changed:

   What|Removed |Added

 CC||mte90...@gmail.com

--- Comment #16 from Daniele Scasciafratte  ---
Created attachment 167600
  --> https://bugs.kde.org/attachment.cgi?id=167600=edit
recent crash with 23.08.1 and all the dbg packages

I am getting this on debian sid with 23.08.1, ref
https://new.reddit.com/r/kde/comments/1bkw01f/dolphin_crash_how_to_open_a_ticket/

I have all the dbgsym packages on my machine

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 477425] Crash in UpdateItemStatesThread::run

2024-02-01 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=477425

Nicolas Fella  changed:

   What|Removed |Added

 CC||josefine.hofmarcher@gmail.c
   ||om

--- Comment #15 from Nicolas Fella  ---
*** Bug 480663 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 477425] Crash in UpdateItemStatesThread::run

2023-12-05 Thread Méven Car
https://bugs.kde.org/show_bug.cgi?id=477425

--- Comment #14 from Méven Car  ---
(In reply to David Edmundson from comment #13)
> -- Backtrace:
> Application: Dolphin (dolphin), signal: Bus error
> Content of s_kcrashErrorMessage: {_M_t = { std::default_delete >> = {_M_t = std::tuple containing = {[1] =
> 0x0, [2] = {}}}, }}
> [KCrash Handler]
> #6  QHashNode::same_key
> (key0=..., h0=1158673663, this=0x7f924d5b362b) at
> /usr/include/qt/QtCore/qhash.h:156
> #7  QHash::findNode
> (this=this@entry=0x557650494c28, akey=..., h=1158673663) at
> /usr/include/qt/QtCore/qhash.h:931
> #8  0x7f96300cbc4a in QHash KVersionControlPlugin::ItemVersion>::findNode (ahp=0x0, akey=...,
> this=0x557650494c28) at /usr/include/qt/QtCore/qhash.h:950
> #9  QHash::contains (akey=...,
> this=0x557650494c28) at /usr/include/qt/QtCore/qhash.h:920
> #10 FileViewGitPlugin::beginRetrieval (this=0x7f95eccc5608, directory=...)
> at /usr/src/debug/dolphin-plugins-22.04.0/git/fileviewgitplugin.cpp:242
> #11 0x7f964180676a in UpdateItemStatesThread::run (this=0x557650336f60)
> at
> /usr/src/debug/dolphin-22.04.0/src/views/versioncontrol/
> updateitemstatesthread.cpp:36
> 
> 
> best trace

I wonder if that happens still with Qt6 since QHash impl has changed.

This trace does not match the previous one that concerned
`kdeconnectfileitemaction.so`.

Some of the duplicates seem not be duplicates either.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 477425] Crash in UpdateItemStatesThread::run

2023-11-28 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=477425

Bug Janitor Service  changed:

   What|Removed |Added

   Priority|HI  |VHI

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 477425] Crash in UpdateItemStatesThread::run

2023-11-28 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=477425

David Edmundson  changed:

   What|Removed |Added

Summary|Dolphin Crashes in  |Crash in
   |Background  |UpdateItemStatesThread::run
 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.