[drkonqi] [Bug 405597] Uninformative error message in KCrash when overwriting stacktrace

2019-07-03 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=405597

Harald Sitter  changed:

   What|Removed |Added

 CC||alanbo...@gmail.com

--- Comment #5 from Harald Sitter  ---
*** Bug 355087 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[drkonqi] [Bug 405597] Uninformative error message in KCrash when overwriting stacktrace

2019-06-07 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=405597

--- Comment #4 from Harald Sitter  ---
Git commit c8f8b9d962eb7c0b638fbe6ded725a46cb5bbf84 by Harald Sitter.
Committed on 07/06/2019 at 12:19.
Pushed by sitter into branch 'Plasma/5.16'.

use errorString instead of errorText

Summary:
the former is for user display, the latter is a sparse variant for
internal use. this results in nicer/useful error messages on errors
CHANGELOG: Error message when failing to save backtraces are more helpful.

Test Plan: - error is a readable string with description instead of only a file
path now

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21644

M  +1-1src/drkonqi.cpp

https://commits.kde.org/drkonqi/c8f8b9d962eb7c0b638fbe6ded725a46cb5bbf84

-- 
You are receiving this mail because:
You are watching all bug changes.

[drkonqi] [Bug 405597] Uninformative error message in KCrash when overwriting stacktrace

2019-06-07 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=405597

Harald Sitter  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/drk
   ||onqi/0d35055d867acd8c2a7db4
   ||d13cf9bd13d18fe558
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.16.1

--- Comment #3 from Harald Sitter  ---
Git commit 0d35055d867acd8c2a7db4d13cf9bd13d18fe558 by Harald Sitter.
Committed on 07/06/2019 at 12:19.
Pushed by sitter into branch 'Plasma/5.16'.

copy backtrace file with overwrite flag

Summary:
QFileDialog was already run with confirmOverwrite, but we didn't actually
set the Overwrite flag on the copy call, so we got an error back when
the file already existed. Since the user already needed to confirm the
overwrite in the QFD we can always pass Overwrite.
CHANGELOG: Saving backtraces now overwrites files when necessary
FIXED-IN: 5.16.1

Test Plan:
- save backtrace
- save again
- dialog asks to confirm overwrite
- gets overwritten succesfully

- save again
- refuse to overwrite
- dialog stays open until cancel or new path is chosen
- no overwrite

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21645

M  +6-1src/drkonqi.cpp

https://commits.kde.org/drkonqi/0d35055d867acd8c2a7db4d13cf9bd13d18fe558

-- 
You are receiving this mail because:
You are watching all bug changes.

[drkonqi] [Bug 405597] Uninformative error message in KCrash when overwriting stacktrace

2019-04-16 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405597

Patrick Silva  changed:

   What|Removed |Added

Summary|Uninformative error message |Uninformative error message
   |in KCrash when saving   |in KCrash when overwriting
   |stacktrace  |stacktrace
 CC||bugsefor...@gmx.com

--- Comment #2 from Patrick Silva  ---
Reproducible on Arch Linux running plasma 5.15.4.

-- 
You are receiving this mail because:
You are watching all bug changes.