https://bugs.kde.org/show_bug.cgi?id=407945
Nate Graham changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/eli
||sa/abd7c706965e1b10cd1fd227
||b828ae1ddb37fcd7
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Nate Graham ---
Git commit abd7c706965e1b10cd1fd227b828ae1ddb37fcd7 by Nate Graham.
Committed on 30/05/2019 at 16:13.
Pushed by ngraham into branch '0.4'.
Port GridBrowser Delegate UI changes to FileBrowserDelegate too
Summary:
When I did D20581, I forgot to do the File Browser view too. This patch ports
the UI
changes done in D20581.
Side note: it feels like these two delegates should really be using the same
paramaterized
components rather than mostly sharing the same code which must then be kept in
sync. This
one also has no test coverage; even more reason to move towards using the
GridBrowserDelegate
for both.
Test Plan:
Tests still pass; UI now looks the same as the grid items in other views
{F6857184}
Reviewers: mgallien, #elisa
Reviewed By: mgallien, #elisa
Differential Revision: https://phabricator.kde.org/D21469
M +51 -56 src/qml/FileBrowserDelegate.qml
https://commits.kde.org/elisa/abd7c706965e1b10cd1fd227b828ae1ddb37fcd7
--
You are receiving this mail because:
You are watching all bug changes.