[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-03-20 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=416131

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/kde/
   ||elisa/commit/e674a748c18b14
   ||161d71538522c33838c1735f52
 Resolution|--- |FIXED

--- Comment #15 from Matthieu Gallien  ---
Git commit e674a748c18b14161d71538522c33838c1735f52 by Matthieu Gallien.
Committed on 20/03/2020 at 15:00.
Pushed by mgallien into branch 'release/20.04'.

fix invalid URL when sending cover image in mpris for embedded covers

use a base 64 encoded data url with inline image data

M  +21   -1src/mpris2/mediaplayer2player.cpp

https://invent.kde.org/kde/elisa/commit/e674a748c18b14161d71538522c33838c1735f52

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-03-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #14 from Nate Graham  ---
Yeah, it's trying to install Elisa on top of the system version in /usr, which
is incorrect. It looks like your ~/.kdesrc-buildrc file is misconfigured. The
correct values in that file are more like this:

# Install directory for KDE software
kdedir ~/kde/usr

# Directory for downloaded source code
source-dir ~/kde/src

# Directory to build KDE into before installing
# relative to source-dir by default
build-dir ~/kde/build


Also these kinds of questions would ideally be asked in the kde-devel channel.
See
https://community.kde.org/Get_Involved#Getting_in_touch_and_working_together

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-03-19 Thread D. Debnath
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #13 from D. Debnath  ---
I tried to run kdesrc-build and it's failing to install (compiled successfully)
with the following error:
CMake Error at cmake_install.cmake:41 (file):
file INSTALL cannot copy file
"/home/debnath/kde/src/elisa/org.kde.elisa.desktop" to
"/usr/share/applications/org.kde.elisa.desktop": Permission denied.

I believe, this is trying to replace the desktop file of my stable Elisa app
from my distro, which is not what it should be doing.

​Also, I tried to kdesrc-run elisa which gives the following error:
QQmlApplicationEngine failed to load component
qrc:/qml/ElisaMainWindow.qml:182:13: Type HeaderBar unavailable
qrc:/qml/HeaderBar.qml:307:25: Type SimplePlayListView unavailable
qrc:/qml/SimplePlayListView.qml:100:13: Type PlayListEntry unavailable
qrc:/qml/PlayListEntry.qml:72:27: Type MediaTrackMetadataView unavailable
qrc:/qml/MediaTrackMetadataView.qml:49:5: EditableTrackMetadataModel is not a
type

From: Matthieu Gallien 
Sent: 20 March 2020 3:04 AM
To: d_debn...@outlook.com 
Subject: [elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media
Player applet

https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #12 from Matthieu Gallien  ---
https://invent.kde.org/kde/elisa/-/merge_requests/105 is a candidate fix
pending review.

Please test if you can ?

--
You are receiving this mail because:
You reported the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-03-19 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #12 from Matthieu Gallien  ---
https://invent.kde.org/kde/elisa/-/merge_requests/105 is a candidate fix
pending review.

Please test if you can ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-03-19 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=416131

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #11 from Matthieu Gallien  ---
I will work on that for the next stable release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-21 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #10 from Matthieu Gallien  ---
Thanks for the analysis work. Well done !

The easiest solution (at least from my point of view) is probably to use data
embedded in the url (https://en.wikipedia.org/wiki/Data_URI_scheme).

That allow to use the data in the track without duplicating it anywhere. This
way the visualization would get the data in a correct way (valid url). It would
look like the current image provider that uses directly the data from the
track.

I can work on that when I will have more time but do not expect me before a few
weeks at least.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-21 Thread Alexander Stippich
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #9 from Alexander Stippich  ---
Though the MPRIS spec does not explicitly state this, I guess it actually needs
a valid url to an image file. In that case, Elisa must extract the image from
the metadata.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #8 from Nate Graham  ---
Interesting. Is there a way to translate this to a file path that the MPRIS
data engine can see? Or would we need to give it the capacity to handle those
kinds of paths by extracting the image on the fly using KFileMetadata or
something?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-21 Thread Alexander Stippich
https://bugs.kde.org/show_bug.cgi?id=416131

Alexander Stippich  changed:

   What|Removed |Added

 CC||a.stipp...@gmx.net

--- Comment #7 from Alexander Stippich  ---
The ones with "image://..." urls are the ones with embedded cover art, which is
dynamically loaded from the file.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #6 from Nate Graham  ---
Created attachment 125065
  --> https://bugs.kde.org/attachment.cgi?id=125065=edit
Song that gives the Media Player applet a valid art URL

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #5 from Nate Graham  ---
Created attachment 125064
  --> https://bugs.kde.org/attachment.cgi?id=125064=edit
Song that causes Media Player applet to receive an invalid art URL

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416131

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #4 from Nate Graham  ---
Never mind, that was a red herring, and this is definitely an Elisa bug.

Using Plasma Engine Explorer (`plasmaengineexplorer`) I can see that the
problem is that *sometimes* Elisa sends the mpris2 data enging an mpris:arturl
metadata tag that looks like "image://cover/home/nate/Music/System of a
Down/Hypnotize/10 She's like Heroin.mp3". URLs like this show no album art in
the Media Player applet. However at other times it sends a file:// URL to an
image file.

For me it depends on the song, which points to some issue in the way the album
art is stores for these songs. I will attach two songs from y collection, one
that triggers the issue and one that does not.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416131

--- Comment #3 from Nate Graham  ---
Ah, I found a way to reliably reproduce this: you need to have multiple
playback streams going such that the applet has a combobox that allows you to
select which one it controls. When the combobox shows "Elisa" or "Choose player
automatically".

Now I'm wondering if this really is Elisa's fault or of it's a bug in the Media
Player applet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-12 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=416131

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #2 from Patrick Silva  ---
Created attachment 125057
  --> https://bugs.kde.org/attachment.cgi?id=125057=edit
strawberry vs elisa

I can confim with elisa 19.12.1 from Arch repos.
Apparently it's a random problem.
My attachment shows strawberry and elisa playing the same file.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 416131] Elisa doesn't export the Album Art to the Media Player applet

2020-01-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416131

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
Created attachment 125051
  --> https://bugs.kde.org/attachment.cgi?id=125051=edit
Works for me

Works for me--for that exact song, even. :)

-- 
You are receiving this mail because:
You are watching all bug changes.