[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-08-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=424154

--- Comment #11 from Nate Graham  ---
That should do it for the final release.

Thanks for your excellent QA, as always. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-08-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=424154

--- Comment #10 from Nate Graham  ---
Git commit adcba7aa89637b2be21e840a6befca9a774986d5 by Nate Graham.
Committed on 02/08/2020 at 15:48.
Pushed by ngraham into branch 'release/20.08'.

Fix excessively tall hit areas for playback and volume sliders

M  +4-5src/qml/MediaPlayerControl.qml

https://invent.kde.org/multimedia/elisa/commit/adcba7aa89637b2be21e840a6befca9a774986d5

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-08-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=424154

--- Comment #9 from Nate Graham  ---
Oh goodness you're right.

I think I know what's up, and I'll fix that too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-08-02 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=424154

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #8 from Patrick Silva  ---
This behavior is still reproducible with Elisa 20.08 RC when I click below the
album name.

Operating System: Arch Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=424154

Nate Graham  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||20.08.0
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/f07a85b
   ||f3adc8619b2af952aa8c4a15bc9
   ||6efede

--- Comment #7 from Nate Graham  ---
Git commit f07a85bf3adc8619b2af952aa8c4a15bc96efede by Nate Graham.
Committed on 27/07/2020 at 21:18.
Pushed by ngraham into branch 'release/20.08'.

Fix misplaced slider backgrounds

Binding x and y to padding values makes no sense, so let's use anchors
instead.
FIXED-IN: 20.08.0

M  +4-6src/qml/MediaPlayerControl.qml

https://invent.kde.org/multimedia/elisa/commit/f07a85bf3adc8619b2af952aa8c4a15bc96efede

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=424154

Nate Graham  changed:

   What|Removed |Added

   Assignee|matthieu_gall...@yahoo.fr   |n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=424154

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/multimedia/elisa/-/merge_requests/138

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=424154

--- Comment #5 from Nate Graham  ---
I have found the problem and will submit a merge request soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=424154

--- Comment #4 from Nate Graham  ---
That change did not result in this regression for me until very recently, so I
suspect some other relevant thing changed between then and now to trigger the
bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424154

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED

--- Comment #3 from Matthieu Gallien  ---
(In reply to Nate Graham from comment #1)
> Yep, I just noticed this. The background is also misplaced, which seems to
> be related.
> 
> We should fix this before 20.08 ships.

I am not sure I understand the problem with respect to the background.

The fact that the active zone of the slider extends to the full height looks
like a deliberate choice made in https://phabricator.kde.org/D22951 . We have
to decide if we want to keep the easy usage of if we want to revert those
changes.

I can confirm that reverting the changes indeed solves the issue here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424154

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Matthieu Gallien  ---
I will work on this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=424154

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||n...@kde.org
   Priority|NOR |VHI
 Status|REPORTED|CONFIRMED
   Keywords||regression

--- Comment #1 from Nate Graham  ---
Yep, I just noticed this. The background is also misplaced, which seems to be
related.

We should fix this before 20.08 ships.

-- 
You are receiving this mail because:
You are watching all bug changes.