[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-23 Thread Timothée Ravier
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #18 from Timothée Ravier  ---
> Yeah, filelight in flatpak is useless.

Just wanted to point out that:
- This is not true.
- This is not proper discourse and does not help. Please avoid using hyperbole
in bug reports.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-23 Thread Timothée Ravier
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #17 from Timothée Ravier  ---
We can do the following:
- Refuse to directly open a directory when started as a Flatpak and open the
file dialog instead to let the user pick it.
- Refuse to open `/` when in a Flatpak.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #16 from farlin...@yandex.ru ---
(In reply to Timothée Ravier from comment #15)
> It's one of those apps where we might just give up and recommend it be
> installed in the base system for it to work properly.

Yeah, I think so :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-23 Thread Timothée Ravier
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #15 from Timothée Ravier  ---
It's one of those apps where we might just give up and recommend it be
installed in the base system for it to work properly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-23 Thread Timothée Ravier
https://bugs.kde.org/show_bug.cgi?id=466077

Timothée Ravier  changed:

   What|Removed |Added

 CC||t...@siosm.fr

--- Comment #14 from Timothée Ravier  ---
Previous work on this front was in:
https://github.com/flathub/org.kde.filelight/pull/12 &
https://github.com/flathub/org.kde.filelight/pull/14

There is only so much we can force through the portal for Filelight. When
Dolphins call Filelight directly, it does not go through a portal and thus does
not have access to the files to scan.

Giving it full host access to does really work well either and needs code
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=466077

farlin...@yandex.ru changed:

   What|Removed |Added

 CC||farlin...@yandex.ru

--- Comment #13 from farlin...@yandex.ru ---
Yeah, filelight in flatpak is useless. If i type "/" in Portal to scan, it
scans only /etc and /run directories. Weird :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-21 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #12 from ratijas  ---
Amazing indeed. I'm pretty sure it's not just one bug, but a combination of
bugs on multiple levels. One of them is entering path manually and hitting
Enter in portals. The rest is probably up to Flatpak / sandboxing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-20 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #11 from Harald Sitter  ---
Ok. This is amazing.

So. Your / scanning trick effectively tricks the dir open dialog into not
passing a portal url but literally file:/// so it scans the inside of the
sandbox, and since that is littered with mounts it effectively only scans /etc
because most everything else is a mount and excluded by the
cross-mount-boundary setting. No surprise the output then looks funky. Either a
bug in kio or xdg-desktop-portal-kde I guess - you shouldn't ever be able to
scan / of the sandbox, it makes no sense to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) is useless

2023-02-20 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=466077

ratijas  changed:

   What|Removed |Added

Summary|Filelight from Flatpak  |Filelight from Flatpak
   |(Flathub)  it useless   |(Flathub)  is useless

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #10 from Harald Sitter  ---
I think that trick is revealing another bug somewhere though. Scanning / this
way leads to fundamentally different results from say /bin

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #9 from ratijas  ---
> Actually. How do you scan root at all? For me the dir open dialog doesn't let 
> me select / at all

That seems to be a leftover of another bug. Yes, folder dialog is very picky
about it. But there's a way: 1) type in "/" manually into the path text field,
2) click "OK" button -- hitting Enter wouldn't work.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #8 from Harald Sitter  ---
Actually. How do you scan root at all? For me the dir open dialog doesn't let
me select / at all

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #7 from ratijas  ---
Not being able to scan root folder when explicitly given access via portal
sounds more like a flatpak bug rather than intentional restriction though

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=466077

Harald Sitter  changed:

   What|Removed |Added

 CC||trav...@redhat.com

--- Comment #6 from Harald Sitter  ---
Well, I mean, it isn't that broken.

The path doesn't matter in the grand scheme of things.
The fact that you can't scan root is why the root scan button was disabled. But
I'll grant you it's a bit crap.
The fact that it is slow is equally not broken, just the cost of doing business
with portals.

What is more interesting is why the home button was removed from flatpaks,
because now we tell users to use the file open dialog, which indeed does
produce crappier results than it needs to for $HOME.

Paging travier for input as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #5 from ratijas  ---
> what you want filelight to do about them? :)

maybe don't package it with Flatpak, if it's usability is so broken inside a
sandbox?

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #4 from Harald Sitter  ---
Yup. That's all design problems of flatpak, not sure what you want filelight to
do about them? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #3 from ratijas  ---
Even if I choose directory explicitly via portals, paths are still displayed
wrong, e.g. some cryptic file:///run/user/1000/doc/24372f9e/ratijas/kde/
instead of /home/ratijas/kde.

And it's literally impossible to give it access to "/" root via portals at all!

Also scanning with flatpaked app feels on a several orders slower than using
unsandboxed one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-20 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=466077

Harald Sitter  changed:

   What|Removed |Added

 CC||sit...@kde.org

--- Comment #2 from Harald Sitter  ---
Well, I mean, it works just fine for $home so that is a bit of an exaggeration.

That said, I am not sure what can be done about this. / in the sandbox is
fundamentally not / outside the sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.

[filelight] [Bug 466077] Filelight from Flatpak (Flathub) it useless

2023-02-19 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=466077

--- Comment #1 from ratijas  ---
No difference with this override:

```
[Context]
filesystems=host-etc:ro;host-os:ro;home:ro;host:ro
```

-- 
You are receiving this mail because:
You are watching all bug changes.