[filelight] [Bug 486549] filelight: doesn't correctly process OneDrive cloud files
https://bugs.kde.org/show_bug.cgi?id=486549 Nate Graham changed: What|Removed |Added Version Fixed In||24.05.1 CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[filelight] [Bug 486549] filelight: doesn't correctly process OneDrive cloud files
https://bugs.kde.org/show_bug.cgi?id=486549 Harald Sitter changed: What|Removed |Added Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util |ities/filelight/-/commit/06 |ities/filelight/-/commit/5d |990b8205d8ad3b270a4fed3c130 |345574db3f5a142ef00fcfd575b |d837a1ecac7 |93ce89353d3 --- Comment #5 from Harald Sitter --- Git commit 5d345574db3f5a142ef00fcfd575b93ce89353d3 by Harald Sitter. Committed on 23/05/2024 at 13:12. Pushed by sitter into branch 'release/24.05'. windows: treat unpinned files as compressed an unpinned file is not present on disk and so we don't actually care about its theoretical size, but rather its actual on-disk size. this in particular covers onedrive files that haven't been pulled onto disk (cherry picked from commit 06990b8205d8ad3b270a4fed3c130d837a1ecac7) M +1-1src/windowsWalker.cpp https://invent.kde.org/utilities/filelight/-/commit/5d345574db3f5a142ef00fcfd575b93ce89353d3 -- You are receiving this mail because: You are watching all bug changes.
[filelight] [Bug 486549] filelight: doesn't correctly process OneDrive cloud files
https://bugs.kde.org/show_bug.cgi?id=486549 Harald Sitter changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/util ||ities/filelight/-/commit/06 ||990b8205d8ad3b270a4fed3c130 ||d837a1ecac7 --- Comment #4 from Harald Sitter --- Git commit 06990b8205d8ad3b270a4fed3c130d837a1ecac7 by Harald Sitter. Committed on 23/05/2024 at 13:09. Pushed by sitter into branch 'master'. windows: treat unpinned files as compressed an unpinned file is not present on disk and so we don't actually care about its theoretical size, but rather its actual on-disk size. this in particular covers onedrive files that haven't been pulled onto disk M +1-1src/windowsWalker.cpp https://invent.kde.org/utilities/filelight/-/commit/06990b8205d8ad3b270a4fed3c130d837a1ecac7 -- You are receiving this mail because: You are watching all bug changes.
[filelight] [Bug 486549] filelight: doesn't correctly process OneDrive cloud files
https://bugs.kde.org/show_bug.cgi?id=486549 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/utilities/filelight/-/merge_requests/124 -- You are receiving this mail because: You are watching all bug changes.
[filelight] [Bug 486549] filelight: doesn't correctly process OneDrive cloud files
https://bugs.kde.org/show_bug.cgi?id=486549 Harald Sitter changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Harald Sitter --- As it turns out processes aren't by default privy to see onedrive files as spares files. That has the advantage that most apps simply don't need to care about what's what. One would need to set RtlSetProcessPlaceholderCompatibilityMode to change that and I am not sure is a good idea because it is NT API and could break things elsewhere in the stack (e.g. in Qt). Unhydrated files seem to have the FILE_ATTRIBUTE_UNPINNED attribute set though, so we could just hold on to that in absence of other information. Supposedly an unpinned file would only ever be ephemerally present, if at all. -- You are receiving this mail because: You are watching all bug changes.
[filelight] [Bug 486549] filelight: doesn't correctly process OneDrive cloud files
https://bugs.kde.org/show_bug.cgi?id=486549
Harald Sitter changed:
What|Removed |Added
CC||sit...@kde.org
--- Comment #1 from Harald Sitter ---
It's curious that both the store version and the CI version have this problem.
bug #473024 seems very related to the problem at hand, but should be fixed in
the CI build.
Specifically
https://learn.microsoft.com/en-us/windows-hardware/drivers/ifs/placeholders
says placeholders are FILE_ATTRIBUTE_SPARSE_FILE which we explicitly handle
differently as per the bug I've mentioned, in CI builds. And we do so using a
function that is documented as "Retrieves the actual number of bytes of disk
storage used to store a specified file." which you would expect should return
1KB as per
https://learn.microsoft.com/en-us/windows/win32/cfapi/build-a-cloud-file-sync-engine#placeholder-files
("Sync engines can create placeholder files that consume only 1 KB of storage
for the filesystem header, and that automatically hydrate into full files under
normal use conditions.").
Needs some inspection what exactly goes on there with onedrive placeholders.
I'd like to avoid having to special case onedrive.
--
You are receiving this mail because:
You are watching all bug changes.
[filelight] [Bug 486549] filelight: doesn't correctly process OneDrive cloud files
https://bugs.kde.org/show_bug.cgi?id=486549 fuyutsuki9...@outlook.com changed: What|Removed |Added CC||fuyutsuki9...@outlook.com -- You are receiving this mail because: You are watching all bug changes.
