[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=384037

Michael Pyne  changed:

   What|Removed |Added

 CC||listes.rusc...@laposte.net

--- Comment #9 from Michael Pyne  ---
*** Bug 389434 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=384037

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=384037

Michael Pyne  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kco
   ||readdons/4bdc7bb199ecd5120a
   ||665600394ac6d69ee1e830
   Version Fixed In||5.39

--- Comment #8 from Michael Pyne  ---
Git commit 4bdc7bb199ecd5120a665600394ac6d69ee1e830 by Michael Pyne.
Committed on 05/10/2017 at 00:53.
Pushed by mpyne into branch 'master'.

desktoptojson: Improve legacy service type detection heuristic.

This commit adds a second-pass heuristic converting requests for named
service types into possible file names for corresponding Desktop Entry
files as used in previous KDE releases.  The current heuristic converts
'/' in the requested service type name to '-'.  If that fails to find a
file, we now also convert '/' to '' (i.e. nothing) and try again before
returning an error.

This fix introduces an autotest regression if you have KDevelop
installed, since the updated code now finds the *real* KDevelop/Plugin
service type desktop entry in a test where it was expecting not to, the
"kdevcppnolanguagesupport no servicetype" test.  To avoid installed
software affecting the tests I rename the service type and verify that
the "no servicetype" and "with [fake] servicetype" tests continue to
pass.
FIXED-IN:5.39

Differential Revision: https://phabricator.kde.org/D8002

M  +1-1autotests/data/servicetypes/fake-kdevelopplugin.desktop
M  +3-3autotests/desktoptojsontest.cpp
M  +23   -6src/lib/plugin/desktopfileparser.cpp

https://commits.kde.org/kcoreaddons/4bdc7bb199ecd5120a665600394ac6d69ee1e830

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Markus]

https://bugs.kde.org/show_bug.cgi?id=384037

Markus  changed:

   What|Removed |Added

 CC||m4rkus...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=384037

Christoph Feck  changed:

   What|Removed |Added

 CC||hering2...@web.de

--- Comment #7 from Christoph Feck  ---
*** Bug 380013 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=384037

--- Comment #6 from Michael Pyne  ---
Created attachment 107947
  --> https://bugs.kde.org/attachment.cgi?id=107947=edit
Potential fix

I'm attaching what I think is a potential fix.  Seems to work OK in my testing
here although I had never really noticed a problem before, so perhaps I'm not
the best one to test.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=384037

Michael Pyne  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1

--- Comment #5 from Michael Pyne  ---
Apologies for the delay, I've been fighting through some hardware issues that
made updating Bugzilla infeasible.

I believe this is a kcoreaddons bug after all.

In commit 49bc26a135bf92bcddecabfdd4f3f71f65540104 we added a heuristic to find
and load old-style services (where the code was not ported to generate or look
for the new JSON plugin format) but this heuristic doesn't find all the
.desktop file entries it might need to locate.

In particular, things like "kwin-effect.desktop", which gives error messages in
systemsettings5 like "kf5.kcoreaddons.desktopparser: Could not locate service
type file kservicetypes5/kwin-effect.desktop, tried ("/home/kde-svn/.local",
"/home/kde-svn/kde-5/share", "/usr/share")".  The file
kservicetypes5/kwineffect.desktop does exist, however.

I'm not quite sure the best way to fix though.  Presumably we'll want to look
for both naming styles.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=384037

--- Comment #4 from Christoph Feck  ---
Michael, does comment #3 provide the requested information? Please set the bug
status.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Sandro Mani]

https://bugs.kde.org/show_bug.cgi?id=384037

--- Comment #3 from Sandro Mani  ---
For clarity, I'm not sure at this point what possible consequences the failure
to load these service files has. But I don't think it's a packaging issue,
since the kwin.spec [1] does not do anything particular to those files, and
also since google returns many of results for that error message, originating
from a variety of distros.

Again for clarity, the issue for this bug report is simply  whether service
file names should be i.e.

kwineffect.desktop

or

kwin-effect.desktop.

In the latter case, the code in the DesktopFileParser::convert should possibly
be

QString fileName = service.toLower().replace(QLatin1Char('/'),
QLatin1String(""))+QStringLiteral(".desktop");

Sorry for the confusion, I had initially misdiagnosed the results of my
debugging session.

[1] https://src.fedoraproject.org/rpms/kwin/blob/master/f/kwin.spec

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=384037

Michael Pyne  changed:

   What|Removed |Added

 CC||arichardson@gmail.com,
   ||mgraess...@kde.org
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Michael Pyne  ---
Hi Sandro,

It looks like you've mixed up the bug report with some attempt at
troubleshooting, but without enough detail on either of those to lead us to a
fix.

As I understand it, the actual issue is that kwin has "some functionality not
working", task switcher in particular.

You think this may be related to Desktop File Parser, I'm guessing based on a
review of logs and console output.  But we don't have enough detail here to
show whether the warning message you saw is really a kwin bug, or perhaps kwin
searching for an old-style kwin-effects as a fallback after properly searching
for kwineffects.desktop.

In other words, KWin might be doing the right thing and DesktopFileParser might
be doing the right thing, with a packaging error of some sort thrown in.  But
it's hard to tell, a lot of the "normal looking" logs we don't have here would
help us to eliminate potential problems.

I'm CC'ing the maintainers for both of these in case either have seen this, but
I would recommend at the very least to attach the full kwin output logs you
have from where you're experiencing issues, and to provide additional detail
about what exactly the problems are (including related issues), what parts of
KWin are still working, graphics drivers in use, the last working version of
kwin and when things stopped working right, etc.  Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 384037] DesktopFileParser::convert: incorrect service file name?

[Sandro Mani]

https://bugs.kde.org/show_bug.cgi?id=384037

--- Comment #1 from Sandro Mani  ---
Hmm actually it does not fix the broken rendering of the taskswitcher (I didn't
notice that compositing got disabled while debugging), but I think the rest of
the issue is still a valid case.

-- 
You are receiving this mail because:
You are watching all bug changes.