[frameworks-kcoreaddons] [Bug 451869] KAboutData does not correctly indicate that later versions of the license can be used

2023-06-09 Thread Soren Stoutner
https://bugs.kde.org/show_bug.cgi?id=451869

Soren Stoutner  changed:

   What|Removed |Added

Version|5.90.0  |5.106.0
 CC||so...@stoutner.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 451869] KAboutData does not correctly indicate that later versions of the license can be used

2022-05-06 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=451869

--- Comment #3 from Ahmad Samir  ---
I think we should update the API docs so that it's clear the OrLater option
only concerns the spdx() method(s).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 451869] KAboutData does not correctly indicate that later versions of the license can be used

2022-05-06 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=451869

--- Comment #2 from Harald Sitter  ---
Last I checked the enum values were a shambles and I've concluded that the API
needs reinventing to instead base on spdx input and output. Everything else is
awkwardly inflexible .

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcoreaddons] [Bug 451869] KAboutData does not correctly indicate that later versions of the license can be used

2022-05-05 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=451869

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com,
   ||sit...@kde.org

--- Comment #1 from Ahmad Samir  ---
I guess you're talking about the "About AppName" action in the Help menu? that
uses KAbstractAboutDialog[1], which uses KAboutLicense::name() to get the label
("License: ...") to show in the dialogue, and KLicenseDialog (the dialogue that
shows the actual license text), which uses KAboutLicense::text().

Neither name() nor text() consider KAboutLicense::OrLaterVersion; the latter
seems to affect the return value of KAboutLicense::spdx()

[1]https://invent.kde.org/frameworks/kxmlgui/-/blob/master/src/kabstractaboutdialog_p.cpp#L84

-- 
You are receiving this mail because:
You are watching all bug changes.