[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2020-11-01 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=403453

Christoph Feck  changed:

   What|Removed |Added

 CC||babrov...@googlemail.com

--- Comment #23 from Christoph Feck  ---
*** Bug 420103 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2020-11-01 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=403453

Christoph Feck  changed:

   What|Removed |Added

 CC||asocial.basta...@gmail.com

--- Comment #21 from Christoph Feck  ---
*** Bug 424174 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2020-11-01 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=403453

Christoph Feck  changed:

   What|Removed |Added

 CC||alex300...@gmail.com

--- Comment #22 from Christoph Feck  ---
*** Bug 427280 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2020-04-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=403453

Christoph Feck  changed:

   What|Removed |Added

 CC||valkai.m...@gmail.com

--- Comment #20 from Christoph Feck  ---
*** Bug 418892 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2020-01-05 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||i...@martin-konrad.net

--- Comment #19 from David Edmundson  ---
*** Bug 415825 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-12-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||andriy18...@gmail.com

--- Comment #18 from David Edmundson  ---
*** Bug 415195 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-08-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||bailong...@gmail.com

--- Comment #17 from David Edmundson  ---
*** Bug 410648 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-08-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||chris+kde...@halbersma.us

--- Comment #15 from David Edmundson  ---
*** Bug 410635 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-08-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

--- Comment #16 from David Edmundson  ---
*** Bug 410005 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-08-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||abys...@gmail.com

--- Comment #14 from David Edmundson  ---
*** Bug 410078 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-08-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||isirase...@gmail.com

--- Comment #13 from David Edmundson  ---
*** Bug 409709 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-06-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||weisswilly1...@gmail.com

--- Comment #12 from David Edmundson  ---
*** Bug 408641 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-06-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||annu...@yahoo.com

--- Comment #11 from David Edmundson  ---
*** Bug 408751 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-06-11 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||adne...@live.com

--- Comment #10 from David Edmundson  ---
*** Bug 385731 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-06-11 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||arberarc...@gmail.com

--- Comment #9 from David Edmundson  ---
*** Bug 403727 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-06-11 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||tecdoor...@hotmail.com

--- Comment #8 from David Edmundson  ---
*** Bug 408540 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-04-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kde
   ||clarative/0aab7d23a2ce155c4
   ||beb5cf77fcac02c93b183b7
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from David Edmundson  ---
Git commit 0aab7d23a2ce155c4beb5cf77fcac02c93b183b7 by David Edmundson.
Committed on 18/04/2019 at 16:14.
Pushed by davidedmundson into branch 'master'.

Plotter: Scope GL Program to lifespan of scenegraph node

Summary:
Currently the QOpenGLProgram was static. This works when you only have
one OpenGL context that is never invalidated.

Instead we shoul have a new program created for each context. There is
no benefit of being static when we can use the cached shader loading.

As we need a program per context, we would need to handle windowChanged
and sceneGraphInvalidated manually. Instead we can scope the program to
the QSGNode which will be deleted and recreated on the render thread
automatically by the scene graph backend.

We can also drop ManagedTextureNode and use
QSGSimpleTextureNode::setOwnsTexture which does the same thing.

Test Plan:
Created a CPU load viewer on my panel
Dragged it to my desktop
Previously that didn't render anything
Now it does

It should fix the crashes that we
see on window moves and handling sceneGraphInvalidated

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20656

M  +66   -40   src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
M  +2-9src/qmlcontrols/kquickcontrolsaddons/plotter.h

https://commits.kde.org/kdeclarative/0aab7d23a2ce155c4beb5cf77fcac02c93b183b7

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-04-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=403453

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-04-18 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=403453

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-04-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||a...@uoguelph.ca

--- Comment #6 from David Edmundson  ---
*** Bug 349289 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-04-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 CC||aaasasham...@mail.ru

--- Comment #5 from David Edmundson  ---
*** Bug 368071 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-04-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=403453

--- Comment #3 from techxga...@outlook.com ---
(In reply to Kai Uwe Broulik from comment #1)
> Crashes in the plotter, probably here:
> 
> s_program->bind();
> s_program->setUniformValue(u_matrix, m_matrix);
> 
> Are you on nvidia?

yes

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-04-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=403453

--- Comment #4 from techxga...@outlook.com ---
My bad

Thought I replied to this bug report

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-03-28 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdeclarative] [Bug 403453] Plotter doesn't handle QQuickWindow::sceneGraphInvalidated

2019-03-28 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=403453

David Edmundson  changed:

   What|Removed |Added

Summary|Plasma shell crashed right  |Plotter doesn't handle
   |as soon as I logged in  |QQuickWindow::sceneGraphInv
   ||alidated
 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.