[frameworks-kholidays] [Bug 365241] The information on Japanese holidays is outdated
https://bugs.kde.org/show_bug.cgi?id=365241 Allen Winter changed: What|Removed |Added Latest Commit|https://commits.kde.org/kho |https://commits.kde.org/kho |lidays/49f6abb6035f97c0a981 |lidays/1c2ecfbf9570752d516f |13e3aedf5d2db135bf63|204d3034cc714e3ff66f Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #9 from Allen Winter --- Git commit 1c2ecfbf9570752d516f204d3034cc714e3ff66f by Allen Winter. Committed on 08/07/2018 at 16:06. Pushed by winterz into branch 'master'. holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect Differential Revision: https://phabricator.kde.org/D13812 M +96 -39 holidays/plan2/holiday_jp_en-us M +96 -47 holidays/plan2/holiday_jp_ja https://commits.kde.org/kholidays/1c2ecfbf9570752d516f204d3034cc714e3ff66f -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kholidays] [Bug 365241] The information on Japanese holidays is outdated
https://bugs.kde.org/show_bug.cgi?id=365241 --- Comment #8 from Jumpei Ogawa --- As I commented in Phabricator, Japanese Equinox Days cannot be calculated automatically. Therefore, I think equinox days should be kept. https://phabricator.kde.org/D13812 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kholidays] [Bug 365241] The information on Japanese holidays is outdated
https://bugs.kde.org/show_bug.cgi?id=365241 phanect...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 CC||phanect...@gmail.com Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #7 from phanect...@gmail.com --- Hey Allen, did you read diff ( https://cgit.kde.org/kholidays.git/commit/?id=49f6abb6035f97c0a98113e3aedf5d2db135bf63 ) when you merge the attached files? The code attached by Firas is based on quite old codebase (July 2016) and it reverts my updates done in May 2017: https://phabricator.kde.org/D5736 https://cgit.kde.org/kholidays.git/commit/?id=f6044686a1768565bcf3d91489f1b080d64c8666 It removes metadata, re-add non-existing holidays (The days listed in "Cultural" section including St. Valentine's Day, Girls' Festival, and Buddha's Birthday are not holidays in Japan), removes comments referring governmental information about holidays. I think your commit 49f6abb should be reverted. I opened request to revert 49f6abb: https://phabricator.kde.org/D13812 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kholidays] [Bug 365241] The information on Japanese holidays is outdated
https://bugs.kde.org/show_bug.cgi?id=365241 Allen Winter changed: What|Removed |Added CC||win...@kde.org --- Comment #6 from Allen Winter --- FYI: I removed the equinox holidays because KHolidays now computes the equinoxes and solstices automatically and adds them to holidays. if the equinoxes in Japan need to be different than the computed values let me know. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kholidays] [Bug 365241] The information on Japanese holidays is outdated
https://bugs.kde.org/show_bug.cgi?id=365241 Allen Winter changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Version Fixed In||5.48.0 Latest Commit||https://commits.kde.org/kho ||lidays/49f6abb6035f97c0a981 ||13e3aedf5d2db135bf63 --- Comment #5 from Allen Winter --- Git commit 49f6abb6035f97c0a98113e3aedf5d2db135bf63 by Allen Winter. Committed on 03/06/2018 at 17:53. Pushed by winterz into branch 'master'. updated Japanese holidays (in Japanese and English) FIXED-IN: 5.48.0 M +39 -96 holidays/plan2/holiday_jp_en-us M +45 -101 holidays/plan2/holiday_jp_ja https://commits.kde.org/kholidays/49f6abb6035f97c0a98113e3aedf5d2db135bf63 -- You are receiving this mail because: You are watching all bug changes.
