[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172
--- Comment #18 from Igor Poboiko ---
Git commit 899c0f7fa457d77f4b53f8540e22290da862d57d by Igor Poboiko.
Committed on 04/06/2020 at 22:03.
Pushed by poboiko into branch 'master'.
[KMainWindow] Invoke QIcon::setFallbackThemeName (later)
Summary:
This is alternative approach to {D22488} and commit 4214045 to KIconThemes.
Okular (and most - if not all - KDE apps) inherit KMainWindow, so KDE apps
should have breeze icons). KMainWindow ctor should be early enough so no icons
are yet loaded, but late enough so QGuiApplication is already inited.
This should be followed by reverting commit 4214045 in KIconThemes.
Original problem description (by @mart):
invoking QIcon::setFallbackThemeName at QCoreApplication ctor
with Q_COREAPP_STARTUP_FUNCTION breaks the internal status of
QIconLoader as it instantiates it before the QPlatformTheme,
but QIconLoader depends from QPlatformTheme to be already instantiated
otherwise it won't load correctly, thus breaking icon loading
in QtQuickControls2 styles, such as Material and Fusion
see https://bugreports.qt.io/browse/QTBUG-74252
Test Plan:
Don't have GTK3 QPA plugin, so cannot test it yet.
I would appreciate if someone helped me with testing :)
Reviewers: aacid, mart, broulik
Subscribers: mart, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D29826
M +17 -0src/kmainwindow.cpp
https://invent.kde.org/frameworks/kxmlgui/commit/899c0f7fa457d77f4b53f8540e22290da862d57d
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 David Rosenstrauch changed: What|Removed |Added CC||dar...@darose.net -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 Antonio Rojas changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |UPSTREAM --- Comment #17 from Antonio Rojas --- I confirm the Qt commit fixes the issue -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 --- Comment #16 from Kevin Kofler --- This is the Qt fix that should fix this: https://codereview.qt-project.org/c/qt/qtbase/+/302581 5.12 LTS backport: https://codereview.qt-project.org/c/qt/qtbase/+/302582 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 Jonathan Chun changed: What|Removed |Added CC||unmonito...@jonathanchun.co ||m --- Comment #15 from Jonathan Chun --- albert -r Albert version: 0.16.1 Build date: Mar 30 2020 02:58:04 Qt version: 5.14.1 QT_QPA_PLATFORMTHEME: Binary location: /usr/local/bin/albert PWD: /home/jchun/Documents/Projects SHELL: /bin/bash LANG: en_US.UTF-8 XDG_SESSION_TYPE: x11 XDG_CURRENT_DESKTOP: KDE DESKTOP_SESSION: /usr/share/xsessions/plasma XDG_SESSION_DESKTOP: KDE OS: KDE neon User Edition 5.18 OS (type/version): neon/18.04 Build ABI: x86_64-little_endian-lp64 Arch (build/current): x86_64/x86_64 Kernel (type/version): linux/5.3.0-45-generic Bumping this to confirm it doesn't work with 5.14 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 --- Comment #14 from Antonio Rojas --- No, it doesn't work with Qt 5.14 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 --- Comment #13 from Kevin Kofler --- (Even if I test fixes, the way I generally go at it is that I develop them against the version that is packaged, test them by adding them as patches to the SRPM, then (before upstreaming them) forward-port them to whatever branch upstream wants patches submitted against.) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 --- Comment #12 from Kevin Kofler --- At most, I could try Qt 5.13.2 with some extra effort (either upgrading my notebook from Fedora 30 to 31 or rebuilding Qt 5.13.2 for Fedora 30, unless it already sits in a Copr somewhere), but 5.14 is not even in Rawhide yet. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 --- Comment #11 from Kevin Kofler --- I can neither confirm nor disprove that at this time, because we do not have Qt 5.14 packaged in Fedora yet. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 --- Comment #10 from Christoph Feck --- Kevin, can you confirm Albert's comment in QTBUG-74252 that it works correctly with Qt 5.14? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 --- Comment #9 from Kevin Kofler --- I would be willing to test and submit a fix, if people tell me (here or at Qt upstream) where the fix should go. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 --- Comment #8 from Kevin Kofler --- Is there anybody here who can answer my question: Should the Plasma platform plugin call QIconLoader::updateSystemTheme()? Or should this maybe even be done somewhere within Qt itself (after loading a platform plugin?), as hinted at in https://bugreports.qt.io/browse/QTBUG-74252 ? We need SOME way to fix this, sooner rather than later (this completely breaks theming in some applications and it has been open for over a year!), and the obvious fix (reverting the KIconThemes addition) does not look like the correct fix to me. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172 Kevin Kofler changed: What|Removed |Added Summary|Compiling against Qt 5.12 |Compiling against Qt 5.12 |breaks QIcon::themeName |breaks QIcon::themeName |with Plama platform plugin |with Plasma platform plugin -- You are receiving this mail because: You are watching all bug changes.
