[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 kloczek changed: What|Removed |Added Ever confirmed|0 |1 Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #13 from kloczek --- I'm going to reopen this ticked because if source tree is configured with BUILD_TESTING=ON it should be added checking dependency for Qt5::QTiffPlugin. Withou that cmake is able configure source tree and there is no any obstacles to start test suite which is failig with ERROR: birthday.pdd: could not load birthday.tif: Unsupported image format -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 Albert Astals Cid changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/kimageformats/commit ||/9b1fafe29bbf1242406d59f392 ||06e62e2bbb6985 --- Comment #12 from Albert Astals Cid --- Git commit 9b1fafe29bbf1242406d59f39206e62e2bbb6985 by Albert Astals Cid, on behalf of Mirco Miranda. Committed on 12/04/2023 at 20:34. Pushed by aacid into branch 'kf5'. Fix wrong alpha conversion and use tif for image comparison in this particular one instead of png D +---autotests/read/psd/birthday.png A +---autotests/read/psd/birthday.tif M +8-3autotests/readtest.cpp M +1-2src/imageformats/psd.cpp https://invent.kde.org/frameworks/kimageformats/commit/9b1fafe29bbf1242406d59f39206e62e2bbb6985 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #11 from Albert Astals Cid --- (In reply to Mirco Miranda from comment #6) > I have no idea how to figure out what is causing this difference. I are we using some pow/sqrt/sin or similar in that code? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #10 from Heiko Becker --- (In reply to Mirco Miranda from comment #7) > I don't like the solution I proposed and it's marked as a draft. In any > case, can you try it? > https://invent.kde.org/frameworks/kimageformats/-/merge_requests/148 Passed here as well, after installing the libqtiff plugin. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #9 from kloczek --- (In reply to Mirco Miranda from comment #7) [..] > https://invent.kde.org/frameworks/kimageformats/-/merge_requests/148 Tested and it works with that MR :) Thank you. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #8 from kloczek --- (In reply to Mirco Miranda from comment #7) [..] > In any case, can you try it? > > https://invent.kde.org/frameworks/kimageformats/-/merge_requests/148 Of course :) One sec .. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #7 from Mirco Miranda --- OK, I played dirty. I modified the test to accept tif images as well as pngs. The tiffs can be saved in premultiplied format, so the test must convert both the image to be tested and the comparison images. Now it works both on my local machine and on invent. I don't like the solution I proposed and it's marked as a draft. In any case, can you try it? https://invent.kde.org/frameworks/kimageformats/-/merge_requests/148 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #6 from Mirco Miranda --- Even on my Debian, the image generated by birthday.ppd is slightly different from the one generated on all CI machines. The difference is on 15 pixels with values like RGB(55,47,54) vs RGB(55,48,54). I have no idea how to figure out what is causing this difference. PS: In the meantime I also fixed a problem I found but it doesn't change the result. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #5 from Mirco Miranda --- Created attachment 157975 --> https://bugs.kde.org/attachment.cgi?id=157975=edit Birthday image generated on CI's VM -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #4 from Mirco Miranda --- Created attachment 157974 --> https://bugs.kde.org/attachment.cgi?id=157974=edit Birthday image generated on my desktop -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 --- Comment #3 from Mirco Miranda --- (In reply to Albert Astals Cid from comment #2) > Mirco, I can also reproduce this locally (CI seems happy though). > > What can we do to help debug this? It's the problem I had about a month ago after my last patch to the psd plugin. For me it worked locally (debian unstable) but failed on invent (all vms). That image is the only one with premultiplied alpha and alpha values other than 255. In my case it changed a few pixels and it seemed due to rounding differences in the conversion from RBG_Premul to ARGB32. I then assumed that my distro (install dated 2006) was the problem and so I used invent's comparison png. To help with debugging I must definitely reintroduce Base64 printing of the image on failure. I do this in the afternoon and then try to figure out what's going on. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 Albert Astals Cid changed: What|Removed |Added CC||mirco...@gmail.com --- Comment #2 from Albert Astals Cid --- Mirco, I can also reproduce this locally (CI seems happy though). What can we do to help debug this? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 468288] kimageformats-read-psd autotest started to fail with 5.105.0
https://bugs.kde.org/show_bug.cgi?id=468288 Albert Astals Cid changed: What|Removed |Added CC||kloczko.tom...@gmail.com --- Comment #1 from Albert Astals Cid --- *** Bug 468292 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
