[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185433

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=426728

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=185433

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/87adf7f6b
   ||cbd9baddafda58e2dbf7052eb32
   ||3358
 Status|ASSIGNED|RESOLVED

--- Comment #19 from David Faure  ---
Git commit 87adf7f6bcbd9baddafda58e2dbf7052eb323358 by David Faure, on behalf
of Andreas Bontozoglou.
Committed on 12/09/2020 at 18:03.
Pushed by dfaure into branch 'master'.

[kio] BUG: Allowing double-quotes in open/save dialog

tl;dr: Allowing double-quotes in filenames in KFileWidget by escaping them with
`\` and modifying the tokenizer to understand this.

In this patch:

- Introduce `escapeDoubleQuotes` function that is used to escape selected file
paths and correctly populate the `locationEdit`

- Disabling old KFileWidgetPrivate::tokenize and writing a new one which works
by iterating each character in the `locationEdit` while it remembers if it is
in "escape mode" (seen a '\') or not.

- Introducing **public API** `KFileWidget::setSelectedUrls`. This was mainly
needed for the tests to work. I originally wanted to test only the tokenizer
but (a) this is in private implementation and (b) testing that things are
escaped properly in the text-box is also very important

- Adding a test for various filenames that contain a mix of backslashes and
quotes

- Adding a new logging category for the kfilewidget.cpp (KIO_KFILEWIDGETS_FW)

- Adding command-line options to `kfilewidgettest_saving_gui` which I used for
functional tests at some point. My work there is a bit sloppy atm but I assume
this is an auxiliary file (let me now if you want me to clean it up)

Questions:

- Do I need to add a @since in the docblock?

- Do I need to change minor/major version here (and how would I do this)? I am
not sure if the addition of `setSelectedUrls` is backwards compatible

M  +105  -0autotests/kfilewidgettest.cpp
M  +9-0src/filewidgets/CMakeLists.txt
M  +98   -46   src/filewidgets/kfilewidget.cpp
M  +8-0src/filewidgets/kfilewidget.h
M  +25   -7tests/kfilewidgettest_saving_gui.cpp

https://invent.kde.org/frameworks/kio/commit/87adf7f6bcbd9baddafda58e2dbf7052eb323358

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185433

--- Comment #18 from Nate Graham  ---
Thanks for working on this, Andreas! Much appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Andreas Bontozoglou]

https://bugs.kde.org/show_bug.cgi?id=185433

--- Comment #17 from Andreas Bontozoglou  ---
Taking this over with an open MR - feel free to take back

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Andreas Bontozoglou]

https://bugs.kde.org/show_bug.cgi?id=185433

Andreas Bontozoglou  changed:

   What|Removed |Added

   Assignee|fa...@kde.org   |a.bontozog...@gmail.com
 CC||a.bontozog...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=185433

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #16 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kio/-/merge_requests/89

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=185433

Patrick Silva  changed:

   What|Removed |Added

 CC||ch...@protonmail.ch

--- Comment #15 from Patrick Silva  ---
*** Bug 424702 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185433

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |VHI

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=185433

glyphi...@gmail.com changed:

   What|Removed |Added

 CC||glyphi...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185433

Nate Graham  changed:

   What|Removed |Added

 CC||lukasz.wojnilow...@gmail.co
   ||m

--- Comment #14 from Nate Graham  ---
*** Bug 355821 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=185433

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[realnobody]

https://bugs.kde.org/show_bug.cgi?id=185433

--- Comment #13 from realnobody  ---
(In reply to realnobody from comment #12)
forget that, I just tried again - and it seems the mentioned "?" case if fixed
in the meantime.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[realnobody]

https://bugs.kde.org/show_bug.cgi?id=185433

--- Comment #12 from realnobody  ---
#c8 mentions percent signs - there are also question marks which cause
problems, see Bug 329259 ... possibly a related cause.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185433

Nate Graham  changed:

   What|Removed |Added

 CC||kdespam34fb987@weg-werf-ema
   ||il.de

--- Comment #11 from Nate Graham  ---
*** Bug 329258 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 185433] Open/save dialog cannot open or save filenames containing double quotes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185433

Nate Graham  changed:

   What|Removed |Added

Summary|Filenames containing double |Open/save dialog cannot
   |quotes cannot be opened |open or save filenames
   |with KFileDialog|containing double quotes
  Component|general |Open/save dialogs
 CC||kdelibs-b...@kde.org,
   ||n...@kde.org
Version|4.10.1  |5.45.0
Product|kfile   |frameworks-kio
   Assignee|kdelibs-b...@kde.org|fa...@kde.org
   Severity|normal  |major
   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.