[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Kai Uwe Broulik changed: What|Removed |Added CC||mdi...@grulic.org.ar --- Comment #16 from Kai Uwe Broulik --- *** Bug 417020 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Nate Graham changed: What|Removed |Added Version Fixed In|5.66.0 |5.67 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Kevin Funk changed: What|Removed |Added Version Fixed In||5.66.0 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Kevin Funk changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kio ||/27271405f4085bd8a398d41a75 ||ac52cb4f857efd Resolution|--- |FIXED --- Comment #15 from Kevin Funk --- Git commit 27271405f4085bd8a398d41a75ac52cb4f857efd by Kevin Funk, on behalf of Julien Goodwin. Committed on 09/01/2020 at 14:17. Pushed by kfunk into branch 'master'. SlaveBase::dispatchLoop: Fix timeout calculation Summary: Old version of the code: ms = qMax(d->nextTimeout.elapsed() - d->nextTimeoutMsecs, 1); ... will mean the sleep is for as long as the timer has run *minus* the intended duration, so if nextTimeoutMsecs is ever set and the timer just started this becomes very negative, and 1ms is the result. Inverting the subtraction: ms = qMax(d->nextTimeoutMsecs - d->nextTimeout.elapsed(), 1); Means sleeping for the remaining time, and so far my CPU seems much happier, with my KIO-HTTP using apps looking fine. Reviewers: chinmoyr, davidedmundson, dfaure, broulik Reviewed By: dfaure Subscribers: ngraham, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D26364 M +1-1src/core/slavebase.cpp https://commits.kde.org/kio/27271405f4085bd8a398d41a75ac52cb4f857efd -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #14 from Jan Killius --- The patch fixed the problem with cover art in the media player from spotify. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Kevin Funk changed: What|Removed |Added CC||andy...@mail.ru --- Comment #13 from Kevin Funk --- *** Bug 400155 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Kevin Funk changed: What|Removed |Added URL||https://phabricator.kde.org ||/D26364 --- Comment #12 from Kevin Funk --- Patch @ https://phabricator.kde.org/D26364 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #11 from Julien Goodwin --- Kevin - I'm not set up for Phabricator, if you're happy to pass the patch on it'd save me setting up an account just for that. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #10 from Kevin Funk --- I think the last patch makes sense. Looks like the subtraction was the wrong way around. Would you mind putting that patch up to Phabricator so it can be reviewed? Or shall I do it? See: https://community.kde.org/Infrastructure/Phabricator -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #9 from Julien Goodwin --- Created attachment 124842 --> https://bugs.kde.org/attachment.cgi?id=124842=edit Invert wait duration subtraction Will need to let it soak to be sure, but it looks like this is at least one major part of the fix, I even called out it in comment 7, but missed the error: ms = qMax(d->nextTimeout.elapsed() - d->nextTimeoutMsecs, 1); Will mean the sleep is for as long as the timer has run *minus* the intended duration, so if nextTimeoutMsecs is ever set, this becomes very negative, and 1ms is the result. Inverting the subtraction: ms = qMax(d->nextTimeoutMsecs - d->nextTimeout.elapsed(), 1); Means sleeping for the remaining time, and so far my CPU seems much happier, with my KIO-HTTP using apps looking fine. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #8 from Julien Goodwin --- Created attachment 124841 --> https://bugs.kde.org/attachment.cgi?id=124841=edit Patch to always set nextTimeoutMsecs to at least 1s. I did a quick build (of the current Debian package), with just the trivial attached patch that should ensure nextTimeoutMsecs is always at least 1 second. This resulted in no notable changes with my usage, but did point me to another probable error, doing a fresh build at the moment. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #7 from Julien Goodwin --- TL;DR of Kevin's notes in 411047#c6: "We're apparently excessively calling QAbstractSocket::waitForReadyRead(msecs=1) in a loop which causes high CPU usage." ... This is called by ConnectionBackend::waitForIncomingTask which just passes down the timeout value from its caller. That caller is SlaveBase::dispatchLoop, which gets its value from: ms = qMax(d->nextTimeout.elapsed() - d->nextTimeoutMsecs, 1); Which should be sane enough assuming nextTimeoutMsecs is non-zero (although personally I think the way the timeouts are done here is silly, a read if available with no wait would be far more sensible with any sleeping being higher up) nextTimeoutMsecs is only ever set if SlaveBase::setTimeoutSpecialCommand is called, otherwise it's zero; notably if setTimeoutSpecialCommand is called with *exactly* zero it gets set to 1000, positive inputs do the obvious, but negative (to cancel) do not do similarly. setTimeoutSpecialCommand is called from HTTPProtocol::httpClose & HTTPProtocol::httpCloseConnection So if somehow they're not called at the end of a request that would leak connections? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Kevin Funk changed: What|Removed |Added CC||kf...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #6 from Kevin Funk --- Also see my observations in https://bugs.kde.org/show_bug.cgi?id=411047#c6 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Kevin Funk changed: What|Removed |Added CC||jkill...@arcor.de --- Comment #5 from Kevin Funk --- *** Bug 411047 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #4 from Nate Graham --- It might be worth posting your patch for comment on https://phabricator.kde.org, even if you know it doesn't fully resolve the issue. Over there, it's more likely to be seen by developers, who can offer you suggestions for improvement. See https://community.kde.org/Infrastructure/Phabricator#Posting_a_Patch_using_the_website -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #3 from Julien Goodwin --- Created attachment 119923 --> https://bugs.kde.org/attachment.cgi?id=119923=edit Patch to make KIO process more events. I ran a copy of KIO with the attached patch for a while, and while it certainly helped reduce the leak, it didn't fully resolve the issue. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 --- Comment #2 from Julien Goodwin --- This has been affecting me for a few months (I run choqok & akgregator, both of which make a heap of background HTTP requests), not sure if it's particularly helpful, but after figuring out the magic to get a sane profile out of linux perf it shows the leaked time is spent in the QCoreApplication::sendPostedEvents call at the end of the main loop in SlaveBase::dispatchLoop. Some quick reading of the code (as a non-QT dev) makes me wonder if the postEventList is getting filled with messages that, for whatever reason, *can't* be delivered. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 392768] KIO::AccessManager keeps ioslave spinning indefinitely
https://bugs.kde.org/show_bug.cgi?id=392768 Julien Goodwin changed: What|Removed |Added CC||jgood...@studio442.com.au --- Comment #1 from Julien Goodwin --- Created attachment 113986 --> https://bugs.kde.org/attachment.cgi?id=113986=edit Flamegraph of kio http.so in affected state -- You are receiving this mail because: You are watching all bug changes.
