[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 Mario Aichinger changed: What|Removed |Added Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram |eworks/kio/commit/fe87d9325 |eworks/kio/commit/e15ab3807 |0d2f9b302e0498cc99a2b7d9fab |944f3d371ce1beb004c4a847498 |7583|9626 Status|REOPENED|RESOLVED Resolution|--- |FIXED Version Fixed In|5.71|5.72 --- Comment #14 from Mario Aichinger --- Git commit e15ab3807944f3d371ce1beb004c4a8474989626 by Mario Aichinger. Committed on 29/06/2020 at 19:47. Pushed by dfaure into branch 'master'. KDirModel: fix hasChildren() regression for trees with hidden files, symlinks, pipes and character devices This is a follow up to commit fe87d932 which fixed hasChildren() for directories with regular files in them. With this commit not only directories with regular files in them are considered as non empty but also directories containing hidden files, symlinks, pipes and character devices. FIXED-IN: 5.72 M +64 -10 autotests/kdirmodeltest.cpp M +27 -7autotests/kiotesthelper.h M +11 -3src/widgets/kdirmodel.cpp https://invent.kde.org/frameworks/kio/commit/e15ab3807944f3d371ce1beb004c4a8474989626 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 --- Comment #13 from Mario Aichinger --- Proposed patch: https://invent.kde.org/frameworks/kio/-/merge_requests/60 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 --- Comment #12 from Mario Aichinger --- Note: This also applies to hidden files (.file). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 Mario Aichinger changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #11 from Mario Aichinger --- Hi David, I have found cases where your patch does not work. I have a directory with only a sym-link in it, this results in the same bug: the directory is not expendable. This also applies to named pipes and character devices. I assume this also happens with block devices but I can not find a test case for it. Mario -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 Wolfgang Bauer changed: What|Removed |Added CC||julien.gar...@gmail.com --- Comment #10 from Wolfgang Bauer --- *** Bug 422205 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 David Faure changed: What|Removed |Added Status|ASSIGNED|RESOLVED Version Fixed In||5.71 Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/kio/commit/fe87d9325 ||0d2f9b302e0498cc99a2b7d9fab ||7583 --- Comment #9 from David Faure --- Git commit fe87d93250d2f9b302e0498cc99a2b7d9fab7583 by David Faure. Committed on 30/05/2020 at 00:56. Pushed by dfaure into branch '2020_05_hasChildren_fix'. KDirModel: fix hasChildren() regression for trees with files shown The logic I introduced in commit ebe7714300af53ba6f4b5cacddb53a2fd52c7d5a assumed that only subdirs were shown in the tree (konqueror sidebar use case). However KDirOperator can also show files, so this introduced bug 419434. Now implemented correctly for both use cases, with unittest. FIXED-IN: 5.71 M +46 -0autotests/kdirmodeltest.cpp M +2-0autotests/kdirmodeltest.h M +5-1src/widgets/kdirmodel.cpp https://invent.kde.org/frameworks/kio/commit/fe87d93250d2f9b302e0498cc99a2b7d9fab7583 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 David Faure changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #8 from David Faure --- Oops. I'll fix it. I think KDirModel can just query the dirlister for the mode. But I'll write a unittest first. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 Christoph Feck changed: What|Removed |Added CC||andrewclimb...@gmail.com --- Comment #7 from Christoph Feck --- *** Bug 422084 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 Méven Car changed: What|Removed |Added CC||meve...@gmail.com --- Comment #6 from Méven Car --- I believe https://phabricator.kde.org/D27731 caused the issue. ebe7714300af53ba6f4b5cacddb53a2fd52c7d5a -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 --- Comment #5 from Christoph Feck --- Could you please submit the patch for review? There might be issues developers want to discuss. https://community.kde.org/Get_Involved/development#Submit_a_patch -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 --- Comment #4 from painless roaster --- Created attachment 128272 --> https://bugs.kde.org/attachment.cgi?id=128272&action=edit fix fix -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 Christoph Feck changed: What|Removed |Added CC||newby...@protonmail.com --- Comment #3 from Christoph Feck --- *** Bug 420020 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 painless roaster changed: What|Removed |Added CC||painless.roas...@gmail.com --- Comment #2 from painless roaster --- Downgrade kf5-kio solved this problem. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 Timothy changed: What|Removed |Added CC||timothy.gouskov@protonmail. ||com --- Comment #1 from Timothy --- I have the same problem. I found a workaround on one of my computers though. I installed Kate via Flatpak, and it's running version 19.12.3. The KDE frameworks is 5.67.0. The Qt is 5.14.1 (built against 5.14.1). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 419434] Folders without sub-folders are not expandable in the TreeView the "Filesystem Browser"
https://bugs.kde.org/show_bug.cgi?id=419434 Christoph Feck changed: What|Removed |Added Ever confirmed|0 |1 Product|kate|frameworks-kio Component|application |URL navigator Assignee|kwrite-bugs-n...@kde.org|fa...@kde.org CC||kdelibs-b...@kde.org Version|19.12.3 |5.68.0 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
