[frameworks-kio] [Bug 452994] Name field doesn't seem to have any history; cannot undo or redo any text changes with Ctrl+Z or Shift+Ctrl+Z
https://bugs.kde.org/show_bug.cgi?id=452994
Christoph Cullmann changed:
What|Removed |Added
Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
|eworks/kio/commit/331aad501 |eworks/kio/commit/42395623a
|acea58013a7cf89e18919f94539 |8fb577a70188b7db6d2b5c42386
|4396|867c
--- Comment #3 from Christoph Cullmann ---
Git commit 42395623a8fb577a70188b7db6d2b5c42386867c by Christoph Cullmann, on
behalf of Ahmad Samir.
Committed on 15/05/2023 at 19:48.
Pushed by cullmann into branch 'master'.
KFileWidget: remove location history dummy-entry related code
This code was used in m_locationEdit ("Name" combobox).
The issue with this code is that it ultimately invokes QLineEdit::setText(),
which resets the undo/redo steps for the text in the lineedit at index -1,
with every key press event.
So we lose one functionality, showing the corresponding icon for the url in
the lineedit, but gain the undo/redo functionality, the latter being a
functionality that is available/expectted in all Qt/KDE lineedits.
0x76b9aa40 in QLineEdit::setText(QString const&)@plt () from
/lib64/libQt5Widgets.so.5
0x76cb8a83 in QComboBoxPrivate::_q_dataChanged (this=0x558f9560,
topLeft=..., bottomRight=...)
0x75e23235 in QAbstractItemModel::dataChanged
(this=this@entry=0x558f9800, _t1=..., _t2=..., _t3=...)
0x766d7780 in QStandardItemModelPrivate::itemChanged (this=, item=item@entry=0x55d8cfe0, roles=...)
0x766d7ff8 in QStandardItem::setData (this=0x55d8cfe0, value=...,
role=)
0x766db16c in QStandardItemModel::setData (role=1, value=...,
index=..., this=0x558f9800)
QStandardItemModel::setData (this=this@entry=0x558f9800, index=...,
value=..., role=role@entry=1)
0x76cb369f in QComboBox::setItemIcon (this=,
index=index@entry=0, icon=...)
0x77f30501 in KFileWidgetPrivate::setDummyHistoryEntry
(this=this@entry=0x556ddbb0, text=..., icon=...,
usePreviousPixmapIfNull=usePreviousPixmapIfNull@entry=true)
M +11 -107 src/filewidgets/kfilewidget.cpp
https://invent.kde.org/frameworks/kio/commit/42395623a8fb577a70188b7db6d2b5c42386867c
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kio] [Bug 452994] Name field doesn't seem to have any history; cannot undo or redo any text changes with Ctrl+Z or Shift+Ctrl+Z
https://bugs.kde.org/show_bug.cgi?id=452994 Nate Graham changed: What|Removed |Added Version Fixed In||5.97 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 452994] Name field doesn't seem to have any history; cannot undo or redo any text changes with Ctrl+Z or Shift+Ctrl+Z
https://bugs.kde.org/show_bug.cgi?id=452994
Ahmad Samir changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Latest Commit||https://invent.kde.org/fram
||eworks/kio/commit/331aad501
||acea58013a7cf89e18919f94539
||4396
Resolution|--- |FIXED
--- Comment #2 from Ahmad Samir ---
Git commit 331aad501acea58013a7cf89e18919f945394396 by Ahmad Samir.
Committed on 03/07/2022 at 19:26.
Pushed by ahmadsamir into branch 'master'.
KFileWidget: remove location history dummy-entry related code
This code was used in m_locationEdit ("Name" combobox).
The issue with this code is that it ultimately invokes QLineEdit::setText(),
which resets the undo/redo steps for the text in the lineedit at index -1,
with every key press event.
So we lose one functionality, showing the corresponding icon for the url in
the lineedit, but gain the undo/redo functionality, the latter being a
functionality that is available/expectted in all Qt/KDE lineedits.
0x76b9aa40 in QLineEdit::setText(QString const&)@plt () from
/lib64/libQt5Widgets.so.5
0x76cb8a83 in QComboBoxPrivate::_q_dataChanged (this=0x558f9560,
topLeft=..., bottomRight=...)
0x75e23235 in QAbstractItemModel::dataChanged
(this=this@entry=0x558f9800, _t1=..., _t2=..., _t3=...)
0x766d7780 in QStandardItemModelPrivate::itemChanged (this=, item=item@entry=0x55d8cfe0, roles=...)
0x766d7ff8 in QStandardItem::setData (this=0x55d8cfe0, value=...,
role=)
0x766db16c in QStandardItemModel::setData (role=1, value=...,
index=..., this=0x558f9800)
QStandardItemModel::setData (this=this@entry=0x558f9800, index=...,
value=..., role=role@entry=1)
0x76cb369f in QComboBox::setItemIcon (this=,
index=index@entry=0, icon=...)
0x77f30501 in KFileWidgetPrivate::setDummyHistoryEntry
(this=this@entry=0x556ddbb0, text=..., icon=...,
usePreviousPixmapIfNull=usePreviousPixmapIfNull@entry=true)
M +11 -107 src/filewidgets/kfilewidget.cpp
https://invent.kde.org/frameworks/kio/commit/331aad501acea58013a7cf89e18919f945394396
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kio] [Bug 452994] Name field doesn't seem to have any history; cannot undo or redo any text changes with Ctrl+Z or Shift+Ctrl+Z
https://bugs.kde.org/show_bug.cgi?id=452994 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #1 from Ahmad Samir --- https://invent.kde.org/frameworks/kio/-/merge_requests/808 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 452994] Name field doesn't seem to have any history; cannot undo or redo any text changes with Ctrl+Z or Shift+Ctrl+Z
https://bugs.kde.org/show_bug.cgi?id=452994 Nate Graham changed: What|Removed |Added Component|general |Open/save dialogs Assignee|br...@frogmouth.net |kio-bugs-n...@kde.org Keywords||usability Summary|KDialog's Name field|Name field doesn't seem to |doesn't seem to have any|have any history; cannot |history. Cannot undo or |undo or redo any text |redo any text changes with |changes with Ctrl+Z or |Ctrl+Z or Shift+Ctrl+Z |Shift+Ctrl+Z Product|kdialog |frameworks-kio Ever confirmed|0 |1 Status|REPORTED|CONFIRMED Version|unspecified |5.93.0 CC||kdelibs-b...@kde.org, ||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
