[frameworks-kio] [Bug 454619] Threading-related crash in Gwenview in file KIO worker

2022-06-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=454619

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/215c03d98
   ||fb7f47cdc673178cedb9a505897
   ||67c7
 Status|REPORTED|RESOLVED

--- Comment #2 from David Faure  ---
Git commit 215c03d98fb7f47cdc673178cedb9a50589767c7 by David Faure.
Committed on 03/06/2022 at 19:48.
Pushed by dfaure into branch 'master'.

kio_file: fix data race on static user cache

Now that the kio_file code runs in threads, static data leads to data
races and should be thread_local instead.

Reproduced the issue by running the new test
./jobtest multipleListRecursive
in a TSAN build, after adding QThread::msleep(50) in WorkerThread::run.
Running this test alone will actually fail the test in any case, but that
doesn't matter, TSAN tells us about the data race.
Even with this fix, it still shouts about KUser not being threadsafe,
I'll fix this in KCoreAddons separately.

M  +47   -13   autotests/jobtest.cpp
M  +1-0autotests/jobtest.h
M  +2-3src/ioslaves/file/file_unix.cpp

https://invent.kde.org/frameworks/kio/commit/215c03d98fb7f47cdc673178cedb9a50589767c7

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 454619] Threading-related crash in Gwenview in file KIO worker

2022-06-03 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=454619

--- Comment #1 from David Faure  ---
https://invent.kde.org/frameworks/kio/-/merge_requests/861

https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/231

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 454619] Threading-related crash in Gwenview in file KIO worker

2022-06-01 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=454619

David Faure  changed:

   What|Removed |Added

   Assignee|kio-bugs-n...@kde.org   |fa...@kde.org
 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.