[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 Méven Car changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/kio/-/commit/4ded5dd ||12f5e752674b685833b77b9b546 ||c0b6c8 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Méven Car --- Git commit 4ded5dd12f5e752674b685833b77b9b546c0b6c8 by Méven Car, on behalf of Harald Sitter. Committed on 15/03/2024 at 18:12. Pushed by meven into branch 'master'. connectionbackend: improve jumbo packet handling (also should fix things on windows) jumbo handling was a bit weird in that we kept bumping the buffer size sky high. and then eventually (hopefully) would be able to read everything in one go and emit. In practice that seems to have not worked out on windows. do partial reads instead. to facilitate this change the existing Task struct is now serving as container we read into so it becomes a bit easier to manage the state. this should also make the code a bit easier to reason about. when we have no task we now start a new task. if we have a task we always read as much data as possible into the task. when we read all data then the task gets emitted. M +9-0autotests/CMakeLists.txt A +53 -0autotests/connectionbackendtest.cpp [License: LGPL(v2.0+)] M +9-0src/core/CMakeLists.txt M +22 -25 src/core/connectionbackend.cpp M +7-6src/core/connectionbackend_p.h https://invent.kde.org/frameworks/kio/-/commit/4ded5dd12f5e752674b685833b77b9b546c0b6c8 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 --- Comment #8 from Jean-Baptiste Mardelle --- Thanks a lot Harald, fantastic !! I can confirm that your MR fixes the issue in my tests on Windows. Lowering KIO_MAX_ENTRIES_PER_BATCH to 50 as a hotfix also allows browsing larger directories. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 --- Comment #7 from Harald Sitter --- As immediate hotfix you could probably patch KIO_MAX_ENTRIES_PER_BATCH to a much lower value - creating more smaller packets instead of fewer large ones. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #6 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/1563 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 Harald Sitter changed: What|Removed |Added CC||sit...@kde.org --- Comment #5 from Harald Sitter --- For me craft wants to patch kiconthemes and fails so I can't really build things to look at. I am rather guessing that the problem is with the file worker sending too large packets though. Jumbo packet handling is very unreliable in my experience (there may well be a bug in it, but I haven't had the motivation to debug this). I'd argue the packet should be broken up into smaller pieces anyway what with reducing memory pressure. First task I guess is finding where the jumbo packet comes from exactly. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 Friedrich W. H. Kossebau changed: What|Removed |Added CC|kosse...@kde.org| --- Comment #4 from Friedrich W. H. Kossebau --- Sorry, never really worked on or reasoned in detail about this part of code, only touched it for simple changes, also no time currently. This needs someone active here, with good KIO overview (cmp. https://invent.kde.org/frameworks/kio/-/commits/master for candidates), so have to unsubscribe me again. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 Jean-Baptiste Mardelle changed: What|Removed |Added CC||kosse...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 481311] KDirLister freezing when trying to parse a folder with more than 178 files
https://bugs.kde.org/show_bug.cgi?id=481311 Jean-Baptiste Mardelle changed: What|Removed |Added Summary|KDirOperator freezing when |KDirLister freezing when |trying to parse a folder|trying to parse a folder |with more than 178 files|with more than 178 files -- You are receiving this mail because: You are watching all bug changes.
