[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=418447

--- Comment #9 from Nate Graham  ---
*** Bug 418966 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=418447

--- Comment #10 from Nate Graham  ---
Yep, same issue. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-23 Thread ariasuni
https://bugs.kde.org/show_bug.cgi?id=418447

ariasuni  changed:

   What|Removed |Added

 CC||pe...@hack-libre.org

--- Comment #8 from ariasuni  ---
Bug 418966 could be a duplicate.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=418447

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.69

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-18 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=418447

--- Comment #7 from Patrick Silva  ---
*** Bug 417438 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-18 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=418447

--- Comment #6 from Patrick Silva  ---
*** Bug 407464 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-18 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=418447

--- Comment #5 from Patrick Silva  ---
This patch also fixes bug 417438 and bug 407464 on Neon unstable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-18 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=418447

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/qqc
   ||2-desktop-style/b738ebbb636
   ||9e4c1d9705b4e0c6e0fba4f96bd
   ||5d
 Status|REPORTED|RESOLVED

--- Comment #4 from Kai Uwe Broulik  ---
Git commit b738ebbb6369e4c1d9705b4e0c6e0fba4f96bd5d by Kai Uwe Broulik.
Committed on 18/03/2020 at 09:09.
Pushed by broulik into branch 'master'.

Fix sizing of CheckBox and RadioButton

KQuickStyleItem manages its implicit size internally. Overriding it on the QML
side makes it non-deterministic
which assignment wins and might cause unexpected re-evaluation of the size
causing it to change.

Moreover, the CheckIndicator implicit size is based on sizeFromContents for
CT_CheckBox, which in case of Breeze
(but not the Qt built-in styles) already contains some extra padding on the
side between checkbox and label.
Instead of using that for layouting our full checkbox (indicator + label), do
what qqc1 did and use
PM_CheckBoxLabelSpacing for spacing and PM_IndicatorWidth as size hint for the
indicator.

Also while at it for radio buttons use the appropriate
(PM_RadioButtonLabelSpacing and PM_ExclusiveIndicatorWidth) hints.

This makes QQC2 CheckBox and RadioButton layouted pixel-perfect to their
QWidget counterparts and also fixes
it randomly changing size hints as you switch between pages as demonstrated by
the bug report.

Differential Revision: https://phabricator.kde.org/D28116

M  +6-5org.kde.desktop/CheckBox.qml
M  +0-3org.kde.desktop/CheckIndicator.qml
M  +6-5org.kde.desktop/RadioButton.qml
M  +6-0plugin/kquickstyleitem.cpp

https://commits.kde.org/qqc2-desktop-style/b738ebbb6369e4c1d9705b4e0c6e0fba4f96bd5d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=418447

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=417438

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=418447

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=407464

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=418447

--- Comment #2 from Nate Graham  ---
*** Bug 418534 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=418447

--- Comment #3 from Nate Graham  ---
*** Bug 418535 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-06 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=418447

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #1 from Patrick Silva  ---
The following bugs seem related:
bug 407464
bug 417438
bug 418534
bug 418535

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 418447] Vertical spacing between FormLayout checkboxes is too high until the control draws itself again

2020-03-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=418447

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.