[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2023-04-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459284

--- Comment #8 from Nate Graham  ---
*** Bug 467791 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-11-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459284

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-11-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459284

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #7 from Nate Graham  ---
The fix had to be reverted because it broke Info Center; re-opening.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-11-15 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=459284

Marco Martin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kirigami/commit/b73f
   ||7b9d1fb7a08dd905616062ac678
   ||20fa8969e
 Status|ASSIGNED|RESOLVED

--- Comment #6 from Marco Martin  ---
Git commit b73f7b9d1fb7a08dd905616062ac67820fa8969e by Marco Martin.
Committed on 15/11/2022 at 12:51.
Pushed by mart into branch 'master'.

Fix binding loop

accessing implicitheight of a child from the parent causes a binding
loop, accessing he height seems to fix it

M  +1-5src/controls/ScrollablePage.qml

https://invent.kde.org/frameworks/kirigami/commit/b73f7b9d1fb7a08dd905616062ac67820fa8969e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-11-07 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=459284

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kirigami/-/merge_requests/819

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-11-07 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=459284

--- Comment #4 from Marco Martin  ---
propagating implicitheight from child to parent should be ok, I'm not sure why
itdoes loops..

however, that code indeed is not pretty, is a bit of a acrobatics to make old
code work, I think is one of the things when branching occurs i'm going to
change making it better code, by allowing a single child as main content. (and
knowingly break some apps in the process, but that is the only moment it can be
done at all)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-10-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459284

Nate Graham  changed:

   What|Removed |Added

 CC||kol...@aon.at

--- Comment #3 from Nate Graham  ---
*** Bug 461152 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-10-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459284

Nate Graham  changed:

   What|Removed |Added

 CC||gravityfa...@pm.me

--- Comment #2 from Nate Graham  ---
*** Bug 458651 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-10-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459284

Nate Graham  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 459284] Every ScrollablePage implementation sends a binding loop error for its MouseArea

2022-09-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459284

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Nate Graham  ---
This code looks suspicious:

height: Math.max(root.flickable.height, implicitHeight)
implicitHeight: {
let impl = 0;
for (let i in itemsParent.visibleChildren) {
let child = itemsParent.visibleChildren[i];
if (child.implicitHeight <= 0) {
impl = Math.max(impl, child.height);
} else {
impl = Math.max(impl, child.implicitHeight);
}
}
return impl + itemsParent.anchors.topMargin +
itemsParent.anchors.bottomMargin;
}

-- 
You are receiving this mail because:
You are watching all bug changes.