https://bugs.kde.org/show_bug.cgi?id=466437

            Bug ID: 466437
           Summary: Kirigami.Dialog has a workaround with particular
                    Breeze qqc2-desktop-style implementation in mind
    Classification: Frameworks and Libraries
           Product: frameworks-kirigami
           Version: Master
          Platform: Other
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: kdelibs-b...@kde.org
          Reporter: m...@ratijas.tk
                CC: notm...@gmail.com
  Target Milestone: Not decided

Created attachment 156734
  --> https://bugs.kde.org/attachment.cgi?id=156734&action=edit
qqc2-desktop-style flat disabled ToolButton

SUMMARY

The following code looks like a workaround for a styling issue in a particular
QQC2 or, more specifically, qqc2-desktop-style implementation, namely Breeze:

> // add custom footer buttons
> Repeater {
>     model: root.customFooterActions
>     // we have to use Button instead of ToolButton, because ToolButton has no 
> visual distinction when disabled
>     delegate: QQC2.Button {
>         flat: flatFooterButtons
>         action: modelData
>         visible: modelData.visible
>     }
> }

This kind of hacks are not suitable for core library components like Dialog.
Besides, the dialog itself should have some sort of templates+styling split in
two components like QQC2. Then, qqc2-desktop-style implementation of Kirigami
templates could use any hacks which are appropriate for known bugs and
limitations.

Actually, this is not even entirely true. The icon of a flat disabled
ToolButton does change opacity. It's just the text that stays bright. However,
the non-flat counterpart fades both text and icon; and the background too. It
looks like a bug in qqc2-desktop-style bridge? Because in QtWidgets, if I set
e.g. toolbar actions in Dolphin to display icons and text, then disabled
Back/Forward flat toolbuttons are fading all at once -- not just icons.

STEPS TO REPRODUCE
1. Open Kirigami/Dialog.qml

OBSERVED RESULT
See workarounds.

EXPECTED RESULT
Upstream bug fixes.

SOFTWARE/OS VERSIONS
KDE Frameworks Version: git/master, git/kf5

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to