[frameworks-knotifications] [Bug 363138] Knotify not logging notifications to file

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363138

Christoph Feck  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kno
   ||tifications/cd83fadb9888ff3
   ||44f7b89deda5b17ecbba94b1c
   Version Fixed In||5.31.0
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Christoph Feck  ---
Git commit cd83fadb9888ff344f7b89deda5b17ecbba94b1c by Christoph Feck.
Committed on 02/02/2017 at 00:26.
Pushed by cfeck into branch 'master'.

Re-add logging notifications to files

Thanks to Gabriel Caudrelier for the investigation.

Differential Revision: https://phabricator.kde.org/D4357
FIXED-IN: 5.31.0

M  +1-1src/CMakeLists.txt
M  +1-2src/knotificationmanager.cpp

https://commits.kde.org/knotifications/cd83fadb9888ff344f7b89deda5b17ecbba94b1c

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knotifications] [Bug 363138] Knotify not logging notifications to file

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363138

--- Comment #4 from Christoph Feck  ---
Thanks for the confirmation. https://phabricator.kde.org/D4357

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knotifications] [Bug 363138] Knotify not logging notifications to file

[Gabriel Caudrelier]

https://bugs.kde.org/show_bug.cgi?id=363138

--- Comment #3 from Gabriel Caudrelier  ---
works fine for me.

Although you probably meant someone more official.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knotifications] [Bug 363138] Knotify not logging notifications to file

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363138

--- Comment #2 from Christoph Feck  ---
I can confirm it correctly compiles with the "NotifyByLogfile" plugin added,
using Qt 5.8 and without KDELibs4Support.

Needs someone able to test it, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knotifications] [Bug 363138] Knotify not logging notifications to file

[Gabriel Caudrelier]

https://bugs.kde.org/show_bug.cgi?id=363138

Gabriel Caudrelier  changed:

   What|Removed |Added

 CC||gabriel.caudrel...@gmail.co
   ||m

--- Comment #1 from Gabriel Caudrelier  ---
This bug is still current.

to fix:

uncomment the line in 
https://cgit.kde.org/knotifications.git/tree/src/knotificationmanager.cpp:80

~~~ code
//FIXME: port and reenable
// addPlugin(new NotifyByLogfile(this));

~~~

I believe this was ported already ... a couple of years ago.

https://cgit.kde.org/knotifications.git/log/src/notifybylogfile.cpp

Just need to re-enable it.

-- 
You are receiving this mail because:
You are watching all bug changes.