[frameworks-krunner] [Bug 398305] FF Bookmarks KRunner does not work with database created with FF 58 or later

2018-10-11 Thread boospy
https://bugs.kde.org/show_bug.cgi?id=398305

--- Comment #7 from boospy  ---
Thanks a lot!! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-krunner] [Bug 398305] FF Bookmarks KRunner does not work with database created with FF 58 or later

2018-10-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=398305

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.14.0  |5.12.8

--- Comment #6 from Nate Graham  ---
Cherry-picked into the 5.12 stable branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-krunner] [Bug 398305] FF Bookmarks KRunner does not work with database created with FF 58 or later

2018-10-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=398305

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/cb99ab735c813 |sma-workspace/99fa6ccc57c50
   |b250f4cd5031b4b078fe0b6c250 |38ffb16d2e999893d55dc91f5b1

--- Comment #5 from Nate Graham  ---
Git commit 99fa6ccc57c5038ffb16d2e999893d55dc91f5b1 by Nate Graham, on behalf
of Stefan Brüns.
Committed on 11/10/2018 at 22:44.
Pushed by ngraham into branch 'Plasma/5.12'.

KRunner: remove no longer existant and unused column from SQL query

Summary:
The favicon_id is not used in the query results, and may not even exist
when the places db has been created with FF 58 or later. In case the
column does not exist the query fails completely.

Test Plan:
1. Create a new FF profile
2. Add some bookmarks
3. Do some queries

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15305

M  +4-4runners/bookmarks/browsers/firefox.cpp

https://commits.kde.org/plasma-workspace/99fa6ccc57c5038ffb16d2e999893d55dc91f5b1

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-krunner] [Bug 398305] FF Bookmarks KRunner does not work with database created with FF 58 or later

2018-10-11 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=398305

--- Comment #4 from Stefan Brüns  ---
Should be in 5.14.0
Backport to 5.12 LTS probably
5.13 - definitely no

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-krunner] [Bug 398305] FF Bookmarks KRunner does not work with database created with FF 58 or later

2018-10-11 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=398305

Oleg Solovyov  changed:

   What|Removed |Added

 CC||mcp...@altlinux.org

--- Comment #3 from Oleg Solovyov  ---
(In reply to boospy from comment #2)
> Thanks for the fix. Waiting for Update in NEON 18.04 :)

Request for backporting this to 5.12 LTS, 5.13 and 5.14 if possible

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-krunner] [Bug 398305] FF Bookmarks KRunner does not work with database created with FF 58 or later

2018-09-09 Thread boospy
https://bugs.kde.org/show_bug.cgi?id=398305

boospy  changed:

   What|Removed |Added

 CC||li...@osit.cc

--- Comment #2 from boospy  ---
Thanks for the fix. Waiting for Update in NEON 18.04 :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-krunner] [Bug 398305] FF Bookmarks KRunner does not work with database created with FF 58 or later

2018-09-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=398305

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.14.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-krunner] [Bug 398305] FF Bookmarks KRunner does not work with database created with FF 58 or later

2018-09-06 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=398305

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/cb99ab735c813
   ||b250f4cd5031b4b078fe0b6c250
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Stefan Brüns  ---
Git commit cb99ab735c813b250f4cd5031b4b078fe0b6c250 by Stefan Brüns.
Committed on 06/09/2018 at 22:55.
Pushed by bruns into branch 'master'.

KRunner: remove no longer existant and unused column from SQL query

Summary:
The favicon_id is not used in the query results, and may not even exist
when the places db has been created with FF 58 or later. In case the
column does not exist the query fails completely.

Test Plan:
1. Create a new FF profile
2. Add some bookmarks
3. Do some queries

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15305

M  +4-4runners/bookmarks/browsers/firefox.cpp

https://commits.kde.org/plasma-workspace/cb99ab735c813b250f4cd5031b4b078fe0b6c250

-- 
You are receiving this mail because:
You are watching all bug changes.