[frameworks-ktexteditor] [Bug 397659] Crash when opening PHP file
https://bugs.kde.org/show_bug.cgi?id=397659 Christoph Cullmann changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/syn ||tax-highlighting/9cfb8fa9a6 ||84917362b6a5ca99e099f5a4353 ||ae6 --- Comment #5 from Christoph Cullmann --- Git commit 9cfb8fa9a684917362b6a5ca99e099f5a4353ae6 by Christoph Cullmann. Committed on 20/08/2018 at 16:59. Pushed by cullmann into branch 'master'. Fix includedDefinitions, handle definition change in context switch AcceptedPublic Fix includedDefinitions, handle definition change in context switch. They were missing, see PHP/HTML. I cleaned up the code a bit to just use QVector, no need for a queue, the order is anyways arbitrary (but stable). Differential Revision: https://phabricator.kde.org/D14952 M +10 -5autotests/syntaxrepository_test.cpp M +19 -15 src/lib/definition.cpp https://commits.kde.org/syntax-highlighting/9cfb8fa9a684917362b6a5ca99e099f5a4353ae6 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 397659] Crash when opening PHP file
https://bugs.kde.org/show_bug.cgi?id=397659 --- Comment #4 from Christoph Cullmann --- Request here https://phabricator.kde.org/D14952 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 397659] Crash when opening PHP file
https://bugs.kde.org/show_bug.cgi?id=397659 Christoph Cullmann changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 --- Comment #3 from Christoph Cullmann --- Have a fix. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 397659] Crash when opening PHP file
https://bugs.kde.org/show_bug.cgi?id=397659 Christoph Cullmann changed: What|Removed |Added CC||cullm...@kde.org --- Comment #2 from Christoph Cullmann --- That means a Format arrives that was not seen for the definition and all its included ones. I thought this was fixed during Akademy. But yeah, it crashs even with the unit test input :/ I register in the constructor only ids: id 1 id 2 id 3 id 4 id 5 id 6 id 7 id 8 id 9 id 10 id 11 id 12 id 56 id 57 id 58 id 59 id 60 id 142 id 143 id 144 id 145 id 146 id 147 id 148 id 149 id 150 id 151 id 152 id 153 id 154 id 155 id 156 id 157 id 158 id 159 id 160 id 161 id 162 id 163 id 164 id 165 id 166 id 167 id 168 id 169 id 170 id 171 id 172 id 173 id 174 id 175 id 176 id 177 id 178 id 179 id 180 id 181 id 182 id 183 id 184 id 185 id 186 id 187 id 188 id 35 id 36 id 37 id 38 id 39 id 40 id 41 id 42 id 43 id 44 id 45 id 46 id 47 id 48 id 49 id 50 id 51 id 52 id 53 id 54 id 55 id 120 id 121 id 122 id 123 id 124 id 125 id 126 id 127 but we get (gdb) print format.id() $3 = 15 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 397659] Crash when opening PHP file
https://bugs.kde.org/show_bug.cgi?id=397659 Volker Krause changed: What|Removed |Added Product|frameworks-syntax-highlight |frameworks-ktexteditor |ing | Component|framework |general CC||vkra...@kde.org --- Comment #1 from Volker Krause --- It's an assert in debug builds three lines up already: ASSERT: "it != m_formatsIdToIndex.end()" in file /k/kde5/src/ktexteditor/src/syntax/katehighlight.cpp, line 258 -- You are receiving this mail because: You are watching all bug changes.
