[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 Nate Graham changed: What|Removed |Added CC||exab...@3mhz.net --- Comment #13 from Nate Graham --- *** Bug 410725 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731
--- Comment #12 from David Hurka ---
Created attachment 120255
--> https://bugs.kde.org/attachment.cgi?id=120255=edit
The new position of the search wrapped popup messages
(In reply to RJVB from comment #8)
> I think the queuing isn't new. Shouldn't really be a problem because how
> often do you let the search wrap ("jump back and forth") under normal use?
> [...]
Actually, I do that very often now. Use case is to compare usages of Okular
class members. (They are often undocumented and I want to know why e. g. a
signal is emitted.)
(In reply to Michael D from comment #2)
> [...] To me, it makes sense to put it somewhere at the bottom
> near the search bar, [...]
It’s not necessarily near the search bar, but it looks fine now. See
attachment.
Thanks for fixing this.
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 Nate Graham changed: What|Removed |Added Version Fixed In|19.04.0 |5.57 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 Nate Graham changed: What|Removed |Added CC||n...@kde.org Version Fixed In||19.04.0 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 Christoph Cullmann changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kte ||xteditor/ac35dba359887e1feb ||881d01ec15db32116943a6 --- Comment #11 from Christoph Cullmann --- Git commit ac35dba359887e1feb881d01ec15db32116943a6 by Christoph Cullmann, on behalf of René J.V. Bertin. Committed on 04/03/2019 at 18:45. Pushed by cullmann into branch 'master'. Restore the search wrapped message to its former type and position. Summary: This fixes issue 398731 by restoring the "search wrapped" info message to its former type and position. Test Plan: works as intended (= as before #cc8b2208) Reviewers: #ktexteditor, dhaumann Reviewed By: #ktexteditor, dhaumann Subscribers: dhaumann, neundorf, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel Tags: #ktexteditor, #kate, #frameworks Differential Revision: https://phabricator.kde.org/D19416 M +2-2src/search/katesearchbar.cpp https://commits.kde.org/ktexteditor/ac35dba359887e1feb881d01ec15db32116943a6 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 RJVB changed: What|Removed |Added URL||https://phabricator.kde.org ||/D19416 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 Dominik Haumann changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #10 from Dominik Haumann --- @René: Could you post the patch on Phabricator? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 --- Comment #9 from David Hurka --- Under normal use: very rarely. It was very convenient for these database summary files, to compare the first and the last entry of the same thing. I didn't install updates on that machine, to keep the corner messages. Split view would have been another possible method, of course. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731
--- Comment #8 from RJVB ---
I think the queuing isn't new. Shouldn't really be a problem because how often
do you let the search wrap ("jump back and forth") under normal use?
I agree that a view flash is like the screen flickering and thus not very
appealing - if you fill the entire screen with that view. But again it would be
only once under normal use. Anyway, we'll see what the devs come up with.
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 --- Comment #7 from David Hurka --- With this patch the messages still queue, when you jump forward and back fast enough. However, in my opinion the messages may do anything, unless they are in the middle of the screen... (In reply to RJVB from comment #3) > Even a brief view background flash would do the trick for me. Hmm, that's like screen flickering. I think, I wouldn't like that. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 --- Comment #6 from RJVB --- Created attachment 116423 --> https://bugs.kde.org/attachment.cgi?id=116423=edit snapshot (I also have a personal patch to make KMessage's less gaudy :) ) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 --- Comment #5 from RJVB --- Created attachment 116422 --> https://bugs.kde.org/attachment.cgi?id=116422=edit patch to revert to simplified previous behaviour I've patched the code for myself, back to using the Information colour (more appropriate IMHO, definitely for my colour scheme) and just pop the message at BottomInView. The previous implementation showed the message at the top or bottom depending on how the search wrapped, but that's needlessly complicated IMHO. We know in what direction we were searching, and I don't see the added value of knowing (confirming) in what sense the search wrapped (beyond the icon already displayed in the message). Those are easy changes for anyone to apply, if they feel like building a framework from source (and installing all required dependencies to do that). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 --- Comment #4 from David Hurka --- (In reply to RJVB from comment #3) > The offending commit: cc8b2208 That's what I was searching for for a long time, before I opened this report. (I did grep -r "Search Wrapped", but without success.) It shouldn't be difficult to change the line > 625: m_wrappedMessage->setPosition(KTextEditor::Message::CenterInView); to something configurable. (I never did something like that.) D9394 (cc8b2208) doesn't provide any references (bug/whishlist reports, etc.), but says that the corner messages weren't prominent enough. Well, maybe they weren't for some users. But I think, users who use the Find Bar (maybe with regular expressions), instead of the Find Bar, know very well what's going on, so the "more prominent" messages are not needed. Would it be OK to change back to the corner messages at least for the Find Bar? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 398731] Search wrapped info message at wrong position
https://bugs.kde.org/show_bug.cgi?id=398731 RJVB changed: What|Removed |Added OS|Linux |All Version|18.08.1 |5.52.0 Platform|Neon Packages |Compiled Sources Component|part|general Product|kate|frameworks-ktexteditor -- You are receiving this mail because: You are watching all bug changes.
