[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Oussema Bouaneni changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=418620 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 --- Comment #19 from Postix --- There's another patch proposed: https://phabricator.kde.org/D25339 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Postix changed: What|Removed |Added CC||pos...@posteo.eu --- Comment #18 from Postix --- *** Bug 414408 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Postix changed: What|Removed |Added CC||dshis...@iitb.ac.in --- Comment #17 from Postix --- *** Bug 415036 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Christoph Cullmann changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #16 from Christoph Cullmann --- For me this works, if the font is chosen properly. If you choose a font that will lead to some fallback for some characters and these have different heights, this fails. If somebody has a proper fix for that case that doesn't lead to rendering artifacts between lines, this can be re-opened. Otherwise I consider this fixed. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Christoph Cullmann changed: What|Removed |Added CC||glyphi...@gmail.com --- Comment #15 from Christoph Cullmann --- *** Bug 412095 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Christoph Cullmann changed: What|Removed |Added CC||l12436...@gmail.com --- Comment #14 from Christoph Cullmann --- *** Bug 387428 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Christoph Cullmann changed: What|Removed |Added CC||efa...@gmail.com --- Comment #13 from Christoph Cullmann --- *** Bug 385798 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Christoph Cullmann changed: What|Removed |Added CC||mister.free...@laposte.net --- Comment #12 from Christoph Cullmann --- *** Bug 390665 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Christoph Cullmann changed: What|Removed |Added CC||t12...@outlook.com --- Comment #11 from Christoph Cullmann --- *** Bug 406432 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Christoph Cullmann changed: What|Removed |Added CC||sdi...@live.de --- Comment #10 from Christoph Cullmann --- *** Bug 404713 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Christoph Cullmann changed: What|Removed |Added CC||cullm...@kde.org --- Comment #9 from Christoph Cullmann --- See latest comments in https://phabricator.kde.org/D19283 If you use proper fonts, that works. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 --- Comment #8 from RJVB --- Created attachment 118450 --> https://bugs.kde.org/attachment.cgi?id=118450=edit both, with shared line background Good idea the check the shaded line background mode. I don't know if this more really paints the entre lineheight (or rather, the text height) but it does show a little bit better what's going on. In particular pasting one of the emojis on a line that didn't have one yet: - shows the line being pushed down (with the reverted commit) as if the emoji is higher - shows the shaded background doesn't change (much) in height. An additional test would be to use Segoe UI Symbol as the editor font, but that's not a monospaced font and I don't know to what extend Kate can handle variable-width fonts. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 --- Comment #7 from Thomas Schöps --- Thanks for adding the image. Comparing the correct and the incorrect version in GIMP, it seems that the patch causes no difference in line height for the font used here. So, the problem must come from the other part of the change: the removal of the second drawing pass workaround. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 RJVB changed: What|Removed |Added Attachment #118436|0 |1 is obsolete|| --- Comment #6 from RJVB --- Created attachment 118449 --> https://bugs.kde.org/attachment.cgi?id=118449=edit 118436: correct rendering, after reverting #ce4194b5bc2e13a6f02d5d03e7b003fa0eba650b -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 --- Comment #5 from Thomas Schöps --- It seems that both uploaded images are the same and both show the incorrect state. I couldn't reproduce this here since the emojis fit into the line with the font that is used here. I am wondering whether the emojis already extended beyond the line height before, but that was hidden by the workaround with the second drawing pass that was applied there. To determine this, it might perhaps be helpful to have a screenshot of the correct state in which the cursor is in one of the lines with an emoji (since this line's background should be of a different color then, making the line height visible). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 --- Comment #4 from Christoph Feck --- The issue is indeed with different fonts getting substituted based on script coverage. Qt only uses the same point size for the fallback fonts, but each font itself is free to use any (pixel) size for the requested point size, mostly depending on the amount of leading the designer felt required. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 Dominik Haumann changed: What|Removed |Added CC||tom.scho...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 --- Comment #3 from Dominik Haumann --- Btw, I don't think this has anything to do with a fallback-font. It's simply that some glyphs force other line heights, and in that case we always lose the game. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 --- Comment #1 from RJVB --- Created attachment 118435 --> https://bugs.kde.org/attachment.cgi?id=118435=edit incorrect lineheight due to #ce4194b5bc2e13a6f02d5d03e7b003fa0eba650b The fallback font used here is Segoe UI Symbol -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 404907] ktexteditor: lineheight regression
https://bugs.kde.org/show_bug.cgi?id=404907 --- Comment #2 from RJVB --- Created attachment 118436 --> https://bugs.kde.org/attachment.cgi?id=118436=edit correct rendering, after reverting #ce4194b5bc2e13a6f02d5d03e7b003fa0eba650b same fallback font in case it wasn't obvious ;) -- You are receiving this mail because: You are watching all bug changes.
