[frameworks-ktexteditor] [Bug 405089] Closing the quotation mark is not smart enough

2019-03-24 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=405089

Christoph Cullmann  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kte
   ||xteditor/714948cac1d12a96f3
   ||d6bad9351480f1fb347450
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.57
 Resolution|--- |FIXED

--- Comment #5 from Christoph Cullmann  ---
Git commit 714948cac1d12a96f3d6bad9351480f1fb347450 by Christoph Cullmann, on
behalf of loh tar.
Committed on 24/03/2019 at 12:48.
Pushed by cullmann into branch 'master'.

DocumentPrivate: Skip auto quotes when these looks already balanced

* Improve readability, const correctness
* const QChar as value, not reference
Related: bug 382960
FIXED-IN: 5.57

Differential Revision: https://phabricator.kde.org/D19598

M  +60   -0autotests/src/katedocument_test.cpp
M  +2-0autotests/src/katedocument_test.h
M  +33   -19   src/document/katedocument.cpp

https://commits.kde.org/ktexteditor/714948cac1d12a96f3d6bad9351480f1fb347450

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 405089] Closing the quotation mark is not smart enough

2019-03-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=405089

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 405089] Closing the quotation mark is not smart enough

2019-03-07 Thread Lothar
https://bugs.kde.org/show_bug.cgi?id=405089

--- Comment #4 from Lothar  ---
> BTW. I case of selection one word I wasn't able to find any shortcut (in 
> editor).

Ctrl-Shift-Left/Right See also Settings->Configure-Shortcuts... But, yes, no
"Select word where cursor is in"

> I have such string:  abcd|e  and I invoke some keyshortcut, which selects 
> this > word, and after just invoke quotation character. In result I get for 
> example: >"abcde"|
> and all of this without taking your hands off the keyboard.

There is some scripting stuff in KTE, perhaps you can help yourself
https://docs.kde.org/stable5/en/applications/katepart/dev-scripting.html

If so, offer your result in https://phabricator.kde.org , if not open a new bug
report for that different issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 405089] Closing the quotation mark is not smart enough

2019-03-07 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=405089

Piotr Mierzwinski  changed:

   What|Removed |Added

 CC||piotr.mierzwin...@gmail.com

--- Comment #3 from Piotr Mierzwinski  ---
(In reply to Lothar from comment #1)

> As workaround could you select the word and hit the quote, which ended in
> "|abcd". However, I'm annoyed too of that and will take a look at it.

Yes is simple and easy when you have only one word (double click solves it, I
mean selects), but in case of sentence it is not so fast, obvious just because
there is need to select whole longer or shorter collection of words and this of
course takes more time.

BTW. I case of selection one word I wasn't able to find any shortcut (in
editor). I think this for sure would speed up selection. Let me explain showing
situation like this:

I have such string:  abcd|e  and I invoke some keyshortcut, which selects this
word, and after just invoke quotation character. In result I get for example:
"abcde"|
and all of this without taking your hands off the keyboard.

Thank you that you will take look at this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 405089] Closing the quotation mark is not smart enough

2019-03-07 Thread Lothar
https://bugs.kde.org/show_bug.cgi?id=405089

Lothar  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #2 from Lothar  ---
https://phabricator.kde.org/D19598

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 405089] Closing the quotation mark is not smart enough

2019-03-06 Thread Lothar
https://bugs.kde.org/show_bug.cgi?id=405089

Lothar  changed:

   What|Removed |Added

 CC||loh@googlemail.com

--- Comment #1 from Lothar  ---
Well, sometimes there is such similar behavior, but in the here mentioned way
can I not reproduce this.
After first hit of double quotes you got "|" (the bar is the cursor) so, typing
then abcd ended in "abcd|", which is fine.

You can have some odd result when you try to add the quotes afterwards to some
word. With our abcd, adding a quote to the begin "abcd is fine, adding then a
quote to the end ended in the mentioned result "abcd"" 

As workaround could you select the word and hit the quote, which ended in
"|abcd". However, I'm annoyed too of that and will take a look at it.

-- 
You are receiving this mail because:
You are watching all bug changes.