[frameworks-ktexteditor] [Bug 405197] KTextEditor : c004f3f787b2b6fd8a1c82a66410f5cb39febf18 breaks patch/.diff file folding
https://bugs.kde.org/show_bug.cgi?id=405197 --- Comment #5 from RJVB --- Created attachment 121587 --> https://bugs.kde.org/attachment.cgi?id=121587&action=edit expected (left) vs. broken (right) folding Well, somewhere between 5.52.0 and 5.60.0 the code folding code incurred a regression which breaks folding of patch/diff files again, see the newly attached screenshot (KDevelop, the left session running with the 5.52.0 frameworks and the right session with the 5.60.0 ones). I think I understand why this happens: the folding now leaves the closing brace visible in C/C++ and apparently it does so by not hiding the last line of the scope-to-be-folded. I liked the old mode (and how you could delete an entire block by folding it and then selecting and deleting 1 apparently line on the screen) but I agree that this new mode is less ambiguous because the opening and closing braces remain visible. However, this is not appropriate for patch files, nor, for instance, for Python files. Fortunately Python files are folded correctly, so this bug should be easy to fix. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 405197] KTextEditor : c004f3f787b2b6fd8a1c82a66410f5cb39febf18 breaks patch/.diff file folding
https://bugs.kde.org/show_bug.cgi?id=405197 Christoph Cullmann changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kte ||xteditor/a8013f3085ef2493e1 ||109fd27ac4db608253636c --- Comment #4 from Christoph Cullmann --- Git commit a8013f3085ef2493e1109fd27ac4db608253636c by Christoph Cullmann. Committed on 13/07/2019 at 18:43. Pushed by cullmann into branch 'master'. fix folding of lines with end position at column 0 of a line the old workaround is no longer needed, the outer level of code handles this the workaround was broken, too, as it didn't use the right line but plainLine(lines() - 1) M +3-15 src/document/katebuffer.cpp https://commits.kde.org/ktexteditor/a8013f3085ef2493e1109fd27ac4db608253636c -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 405197] KTextEditor : c004f3f787b2b6fd8a1c82a66410f5cb39febf18 breaks patch/.diff file folding
https://bugs.kde.org/show_bug.cgi?id=405197 Christoph Cullmann changed: What|Removed |Added CC||cullm...@kde.org --- Comment #3 from Christoph Cullmann --- Current versions behave better, thought still some of the folds miss to fold the last line. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 405197] KTextEditor : c004f3f787b2b6fd8a1c82a66410f5cb39febf18 breaks patch/.diff file folding
https://bugs.kde.org/show_bug.cgi?id=405197 --- Comment #2 from RJVB --- Created attachment 118638 --> https://bugs.kde.org/attachment.cgi?id=118638&action=edit correctly folded file After reverting the incriminated commit. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktexteditor] [Bug 405197] KTextEditor : c004f3f787b2b6fd8a1c82a66410f5cb39febf18 breaks patch/.diff file folding
https://bugs.kde.org/show_bug.cgi?id=405197 --- Comment #1 from RJVB --- Created attachment 118637 --> https://bugs.kde.org/attachment.cgi?id=118637&action=edit misfolded file Result after View/Code Folding/Fold Toplevel Nodes. -- You are receiving this mail because: You are watching all bug changes.
