[frameworks-ktexteditor] [Bug 413848] Drag function (by using Ctrl Key) does not work anymore

2020-01-26 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=413848

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kte
   ||xteditor/33a47ec6ebb84c9ddd
   ||a4f4788df8f94c084ae45e
 Status|REPORTED|RESOLVED

--- Comment #5 from Christoph Cullmann  ---
Git commit 33a47ec6ebb84c9ddda4f4788df8f94c084ae45e by Christoph Cullmann.
Committed on 26/01/2020 at 13:04.
Pushed by cullmann into branch 'master'.

fix Drag function (by using Ctrl Key)

M  +1-1src/view/kateviewinternal.cpp

https://commits.kde.org/ktexteditor/33a47ec6ebb84c9ddda4f4788df8f94c084ae45e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 413848] Drag function (by using Ctrl Key) does not work anymore

2020-01-23 Thread Juraj
https://bugs.kde.org/show_bug.cgi?id=413848

--- Comment #4 from Juraj  ---
(In reply to Christoph Cullmann from comment #3)
> This would fix it for me:
> 
> diff --git a/src/view/kateviewinternal.cpp b/src/view/kateviewinternal.cpp
> index 51e1efc7..b7922eb2 100644
> --- a/src/view/kateviewinternal.cpp
> +++ b/src/view/kateviewinternal.cpp
> @@ -3232,7 +3232,7 @@ void KateViewInternal::doDrag()
>  QMimeData *mimeData = new QMimeData();
>  mimeData->setText(view()->selectionText());
>  m_dragInfo.dragObject->setMimeData(mimeData);
> -m_dragInfo.dragObject->exec(Qt::MoveAction);
> +m_dragInfo.dragObject->exec(Qt::MoveAction | Qt::CopyAction);

Can confirm, this fixes it for me too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 413848] Drag function (by using Ctrl Key) does not work anymore

2020-01-22 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=413848

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #3 from Christoph Cullmann  ---
This would fix it for me:

diff --git a/src/view/kateviewinternal.cpp b/src/view/kateviewinternal.cpp
index 51e1efc7..b7922eb2 100644
--- a/src/view/kateviewinternal.cpp
+++ b/src/view/kateviewinternal.cpp
@@ -3232,7 +3232,7 @@ void KateViewInternal::doDrag()
 QMimeData *mimeData = new QMimeData();
 mimeData->setText(view()->selectionText());
 m_dragInfo.dragObject->setMimeData(mimeData);
-m_dragInfo.dragObject->exec(Qt::MoveAction);
+m_dragInfo.dragObject->exec(Qt::MoveAction | Qt::CopyAction);

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 413848] Drag function (by using Ctrl Key) does not work anymore

2020-01-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=413848

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org,
   ||fa...@kde.org

--- Comment #2 from Albert Astals Cid  ---
David some people claim you broke this with https://phabricator.kde.org/D23964

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 413848] Drag function (by using Ctrl Key) does not work anymore

2020-01-22 Thread Juraj
https://bugs.kde.org/show_bug.cgi?id=413848

--- Comment #1 from Juraj  ---
Hello,
I tracked it down to the revision D23964
https://phabricator.kde.org/D23964

To be exact error is caused by this one change:
https://github.com/KDE/ktexteditor/commit/8f7f22c1fc83a5f18a1701c7c78dae882158de30?diff=unified#diff-fccc06952d6abc88b4b165fc4577eb0fL3240

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 413848] Drag function (by using Ctrl Key) does not work anymore

2019-12-22 Thread Juraj
https://bugs.kde.org/show_bug.cgi?id=413848

Juraj  changed:

   What|Removed |Added

 CC||sgd.or...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.