[frameworks-kwidgetsaddons] [Bug 385158] QDialogButtonBox::Discard is overridden to use "edit-clear" icon; upstream setting ("edit-delete" icon) is correct

2017-10-18 Thread Simon Andric 
https://bugs.kde.org/show_bug.cgi?id=385158

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 385158] QDialogButtonBox::Discard is overridden to use "edit-clear" icon; upstream setting ("edit-delete" icon) is correct

2017-09-28 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=385158

--- Comment #5 from Nate Graham  ---
Thanks, me too! And thanks for cleaning up some of my messes when triaging
bugs. I'll get better over time.

Judging by past experience with previous goal-directed hobbies, you should have
my full-time attention for about 2 years. After that I'll burn out if I either
feel like I'm not making progress, or lose interest if I've achieved the goal I
set out to achieve (Improving KDE software's use cases for regular people such
that I can switch my mother from her Mac and not have it be a support
nightmare). Assuming I'm still making progress and the goal hasn't been
achieved yet, I may just keep working on this stuff for a long time. :)

FWIW, you guys have been amazingly more patient and welcoming than the GNOME
folks were when I first tried to jump on board their train. It's a pleasure to
work together on this project.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 385158] QDialogButtonBox::Discard is overridden to use "edit-clear" icon; upstream setting ("edit-delete" icon) is correct

2017-09-28 Thread Christoph Feck 
https://bugs.kde.org/show_bug.cgi?id=385158

--- Comment #4 from Christoph Feck  ---
Thanks for your bug work, Nate. Hope you don't burn out too soon ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 385158] QDialogButtonBox::Discard is overridden to use "edit-clear" icon; upstream setting ("edit-delete" icon) is correct

2017-09-28 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=385158

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kwi
   ||dgetsaddons/6f30aad51452583
   ||d5bfc6815acae099b3f0e017c

--- Comment #3 from Nate Graham  ---
Git commit 6f30aad51452583d5bfc6815acae099b3f0e017c by Nathaniel Graham.
Committed on 28/09/2017 at 16:43.
Pushed by ngraham into branch 'master'.

Use edit-delete icon for destructive discard action

Summary:

Use edit-delete icon for buttons that execute destructive discard actions. This
is what Upstream Qt originally had, but we were overriding it to use a
less-appropriate icon (edit-clear)

Test Plan:
Tested in KDE Neon. An example of the change can be seen in Spectacle's main
window:
{F4233176}

Reviewers: #frameworks, #vdg, dfaure, rkflx, davidedmundson, cfeck

Reviewed By: cfeck

Subscribers: cfeck, #frameworks

Differential Revision: https://phabricator.kde.org/D8029

M  +1-1src/kstandardguiitem.cpp

https://commits.kde.org/kwidgetsaddons/6f30aad51452583d5bfc6815acae099b3f0e017c

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 385158] QDialogButtonBox::Discard is overridden to use "edit-clear" icon; upstream setting ("edit-delete" icon) is correct

2017-09-28 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=385158

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Nate Graham  ---
Thanks for the info, Kai! I've submitted a patch for this:
https://phabricator.kde.org/D8029

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 385158] QDialogButtonBox::Discard is overridden to use "edit-clear" icon; upstream setting ("edit-delete" icon) is correct

2017-09-28 Thread David Edmundson 
https://bugs.kde.org/show_bug.cgi?id=385158

David Edmundson  changed:

   What|Removed |Added

   Assignee|k...@davidedmundson.co.uk|cf...@kde.org
  Component|general |general
   Target Milestone|1.0 |---
Product|plasmashell |frameworks-kwidgetsaddons
Version|master  |unspecified
 CC||kdelibs-b...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.