[frameworks-kxmlgui] [Bug 365050] KToolBar constant repaint when a QToolButton is added in it

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=365050

David Faure  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kxm |https://commits.kde.org/kwi
   |lgui/ba889143d684326f0b8b19 |dgetsaddons/c6191993c7e5ea4
   |88ea12073c95cc8ffe  |873f0635a6fac79773c9cb96c

--- Comment #3 from David Faure  ---
Git commit c6191993c7e5ea4873f0635a6fac79773c9cb96c by David Faure.
Committed on 07/10/2017 at 16:29.
Pushed by dfaure into branch 'master'.

KAcceleratorManager: set icon text on actions to remove CJK markers

Summary:
This replaces the KToolBar event filter hack to solve the same issue:
when an action text appears in a menu we want the & accelerator, while in
toolbars wewant that removed. Qt takes care of it, except for the more tricky
case of CJK markers: " ()" where  exists only to get an ascii
accelerator.
Instead of hacking the text at painting time (!) it's much more robust to
remove " ()" from action texts and sett hat as the icon text upfront.

With this in, we can remove the KToolBar hack which leads to endless repaints.
Related: bug 377859

Test Plan: Unittest

Reviewers: mardelle, ilic, sandsmark

Subscribers: #frameworks

Differential Revision: https://phabricator.kde.org/D7964

M  +31   -6autotests/kacceleratormanagertest.cpp
M  +1-0src/CMakeLists.txt
A  +106  -0src/common_helpers.cpp [License: LGPL (v2+)]
A  +46   -0src/common_helpers_p.h [License: LGPL (v2+)]
M  +21   -0src/kacceleratormanager.cpp

https://commits.kde.org/kwidgetsaddons/c6191993c7e5ea4873f0635a6fac79773c9cb96c

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 365050] KToolBar constant repaint when a QToolButton is added in it

[Jean-Baptiste Mardelle]

https://bugs.kde.org/show_bug.cgi?id=365050

Jean-Baptiste Mardelle  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kxm
   ||lgui/ba889143d684326f0b8b19
   ||88ea12073c95cc8ffe
 Resolution|--- |FIXED

--- Comment #2 from Jean-Baptiste Mardelle  ---
Git commit ba889143d684326f0b8b1988ea12073c95cc8ffe by Jean-Baptiste Mardelle.
Committed on 06/10/2017 at 06:07.
Pushed by mardelle into branch 'master'.

Fix KToolBar repaint loop
Related: bug 377859
Differential Revision: https://phabricator.kde.org/D7954

M  +10   -4src/ktoolbar.cpp

https://commits.kde.org/kxmlgui/ba889143d684326f0b8b1988ea12073c95cc8ffe

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 365050] KToolBar constant repaint when a QToolButton is added in it

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=365050

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 365050] KToolBar constant repaint when a QToolButton is added in it

[Jean-Baptiste Mardelle via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365050

--- Comment #1 from Jean-Baptiste Mardelle  ---
Created attachment 3
  --> https://bugs.kde.org/attachment.cgi?id=3=edit
Fix repaint loop

After some investigation, I found the line responsible for the endless repaint
loop of QToolButtons in KToolBar (line 1359).

It looks like this line is changing the text of the button inside the paint
event, thus creating an endless repaint loop with the side effects described in
my original report. This code seems to be quite old, but it definitely creates
a repaint loop!

My patch is just a workaround disabling the problematic line, someone with a
better understanding of the code should have a closer look...

-- 
You are receiving this mail because:
You are watching all bug changes.