[frameworks-kxmlgui] [Bug 438580] Expanded tooltips don't work correctly on wayland

2021-06-14 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=438580

David Redondo  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kxmlgui/commit/2fac5
   ||e0540e3276533648915e5aa8322
   ||40e32e12
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #5 from David Redondo  ---
Git commit 2fac5e0540e3276533648915e5aa832240e32e12 by David Redondo.
Committed on 14/06/2021 at 13:24.
Pushed by davidre into branch 'master'.

Hide tooltip instantly before showing whatsthis

QToolTop runs a timer before hiding, on Wayland Qt closes all other popups
opened
that were opened after it when closing a popup. This caused the whatsthis popup
to never show up on Wayland.
Because it's not possible to access the tooltip directly, we search for the
correct
window.

M  +14   -0src/ktooltiphelper.cpp

https://invent.kde.org/frameworks/kxmlgui/commit/2fac5e0540e3276533648915e5aa832240e32e12

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 438580] Expanded tooltips don't work correctly on wayland

2021-06-14 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=438580

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/62

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 438580] Expanded tooltips don't work correctly on wayland

2021-06-14 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=438580

--- Comment #3 from David Redondo  ---
On further inspection looks like it supports clicking inside the text, so it
wants to be able to get input

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 438580] Expanded tooltips don't work correctly on wayland

2021-06-14 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=438580

David Redondo  changed:

   What|Removed |Added

 CC||k...@david-redondo.de

--- Comment #2 from David Redondo  ---
> Does QWhatsThis even need to be grabbing?

I think it could get away with being a tooltip and not a popup, at least our
expandible ones.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 438580] Expanded tooltips don't work correctly on wayland

2021-06-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438580

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 438580] Expanded tooltips don't work correctly on wayland

2021-06-13 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=438580

--- Comment #1 from David Edmundson  ---
Relevant backtrace from the shift press:

Thread 1 "kwrite" hit Breakpoint 1, 0x7fffedc13170 in
QtWaylandClient::QWaylandXdgSurface::setGrabPopup(QtWaylandClient::QWaylandWindow*,
QtWaylandClient::QWaylandInputDevice*, int)@plt ()
   from /opt/qt5/plugins/wayland-shell-integration/libxdg-shell.so
(gdb) bt
#0  0x7fffedc13170 in
QtWaylandClient::QWaylandXdgSurface::setGrabPopup(QtWaylandClient::QWaylandWindow*,
QtWaylandClient::QWaylandInputDevice*, int)@plt ()
   from /opt/qt5/plugins/wayland-shell-integration/libxdg-shell.so
#1  0x7fffedc156e0 in
QtWaylandClient::QWaylandXdgSurface::QWaylandXdgSurface (this=0x5f205f40, 
shell=, surface=, window=)
at
../../../../include/QtWaylandClient/5.15.3/QtWaylandClient/private/../../../../../../src/client/qwaylanddisplay_p.h:203
#2  0x7fffedc15926 in QtWaylandClient::QWaylandXdgShell::getXdgSurface
(this=0x5f125520, 
window=0x5ec98c20)
at
/home/david/projects/qt5/qtwayland/src/plugins/shellintegration/xdg-shell/qwaylandxdgshell.cpp:475
#3  0x7fffedc15941 in
QtWaylandClient::QWaylandXdgShellIntegration::createShellSurface (
this=, window=)
at
/home/david/projects/qt5/qtwayland/src/plugins/shellintegration/xdg-shell/qwaylandxdgshellintegration.cpp:69
#4  0x712fdef1 in QtWaylandClient::QWaylandWindow::initWindow
(this=this@entry=0x5ec98c20)
at /home/david/projects/qt5/qtwayland/src/client/qwaylandwindow.cpp:145
#5  0x712fe67e in QtWaylandClient::QWaylandWindow::setVisible
(this=0x5ec98c20, 
visible=) at
/home/david/projects/qt5/qtwayland/src/client/qwaylandwindow.cpp:437
#6  0x7577996a in QWindowPrivate::setVisible (this=0x5f1bc2f0,
visible=visible@entry=true)
at /home/david/projects/kde5/src/Qt5/qtbase/src/gui/kernel/qwindow.cpp:408
#7  0x75ebac93 in QWidgetWindow::setNativeWindowVisibility
(this=this@entry=0x5f204d50, 
visible=visible@entry=true)
at
/home/david/projects/kde5/src/Qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:215
#8  0x75e942cf in QWidgetPrivate::show_sys
(this=this@entry=0x5f16f7c0)
at
/home/david/projects/kde5/src/Qt5/qtbase/src/widgets/kernel/qwidget.cpp:7893
#9  0x75e9cb2d in QWidgetPrivate::show_helper
(this=this@entry=0x5f16f7c0)
at
/home/david/projects/kde5/src/Qt5/qtbase/src/widgets/kernel/qwidget.cpp:7816
#10 0x75e9f85e in QWidgetPrivate::setVisible (this=0x5f16f7c0,
visible=visible@entry=true)
at
/home/david/projects/kde5/src/Qt5/qtbase/src/widgets/kernel/qwidget.cpp:8112
#11 0x75e9fa10 in QWidget::setVisible (this=0x5f2051d0,
visible=)
at
/home/david/projects/kde5/src/Qt5/qtbase/src/widgets/kernel/qwidget.cpp:8044
#12 0x75e9c7d2 in QWidget::show (this=this@entry=0x5f2051d0)
at
/home/david/projects/kde5/src/Qt5/qtbase/src/widgets/kernel/qwidget.cpp:7670
#13 0x75ecf2fa in QWhatsThisPrivate::say
(widget=widget@entry=0x7fffc948, 
text="If a line has no bookmark then add one, otherwise remove it.", x=127,
y=70)
at
/home/david/projects/kde5/src/Qt5/qtbase/src/widgets/kernel/qwhatsthis.cpp:635
#14 0x75ed0ba0 in QWhatsThis::showText (pos=..., 
text="If a line has no bookmark then add one, otherwise remove it.",
w=0x7fffc948)
at
/home/david/projects/kde5/src/Qt5/qtbase/src/widgets/kernel/qwhatsthis.cpp:649
#15 0x76feca71 in KToolTipHelperPrivate::handleKeyPressEvent
(this=0x5ec77dd0, 
event=0x7fffcca0) at
/home/david/projects/kde5/src/frameworks/kxmlgui/src/ktooltiphelper.cpp:125



#5  0x712fe67e in QtWaylandClient::QWaylandWindow::setVisible
(this=0x5ec98c20, 

(gdb) print closestShellSurfaceWindow(window())
$9 = (QtWaylandClient::QWaylandWindow *) 0x0

None explicitly set.


(gdb) print transientParent()->window()->objectName()
$8 = "MainWindow#1Window"

So we fallback to guessing - and find the main window. 

Does QWhatsThis even need to be grabbing?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kxmlgui] [Bug 438580] Expanded tooltips don't work correctly on wayland

2021-06-13 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=438580

David Edmundson  changed:

   What|Removed |Added

   Priority|NOR |HI
   Keywords||wayland

-- 
You are receiving this mail because:
You are watching all bug changes.