[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-09-05 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=397766

Christoph Cullmann  changed:

   What|Removed |Added

 CC||kobalicek.p...@gmail.com

--- Comment #8 from Christoph Cullmann  ---
*** Bug 398147 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-08-25 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=397766

Christoph Cullmann  changed:

   What|Removed |Added

   Version Fixed In||5.50.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-08-25 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=397766

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/syn
   ||tax-highlighting/365fee5787
   ||c164e9e4a5c17440196456869d0
   ||a14

--- Comment #7 from Christoph Cullmann  ---
Git commit 365fee5787c164e9e4a5c17440196456869d0a14 by Christoph Cullmann.
Committed on 25/08/2018 at 18:42.
Pushed by cullmann into branch 'master'.

fix highlighting for #ifdef _xxx stuff
unit test extended to catch this case

M  +9-0autotests/folding/highlight.cpp.fold
M  +9-0autotests/html/highlight.cpp.html
M  +9-0autotests/input/highlight.cpp
M  +9-0autotests/reference/highlight.cpp.ref
M  +2-2data/syntax/isocpp.xml

https://commits.kde.org/syntax-highlighting/365fee5787c164e9e4a5c17440196456869d0a14

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-08-23 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=397766

--- Comment #5 from Piotr Mierzwinski  ---
Created attachment 114563
  --> https://bugs.kde.org/attachment.cgi?id=114563&action=edit
ifndef incorrect syntax highlighting

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-08-23 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=397766

--- Comment #6 from Piotr Mierzwinski  ---
In attachment screen shots as you asked.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-08-23 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=397766

Piotr Mierzwinski  changed:

   What|Removed |Added

 CC||piotr.mierzwin...@gmail.com

--- Comment #4 from Piotr Mierzwinski  ---
Created attachment 114562
  --> https://bugs.kde.org/attachment.cgi?id=114562&action=edit
ifndef correct syntax highlighting

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-08-23 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=397766

--- Comment #3 from Christoph Cullmann  ---
I think that handling shall be removed.
Your can do #define _ just fine but not #ifdef _

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-08-22 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=397766

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #2 from Christoph Cullmann  ---
I think the issue is that we highlight _+... defines as error because they are
reserved.

That might make sense for #define but I don't think for the uses.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 397766] Underline as first character in name passed to #ifndef breaks highlighting

2018-08-22 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=397766

--- Comment #1 from Dominik Haumann  ---
Please attach a screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.