[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2019-07-13 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=401480

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||cullm...@kde.org
 Status|REPORTED|RESOLVED

--- Comment #12 from Christoph Cullmann  ---
This got fixed ;=)

Don't crash on malformed syntax highlighting files

Test Plan:
1. Create malformed syntax highlighting file with missing end tags
2. Place it in ~/.local/share/katepart5/syntax/
3. Open Kate with file which uses that syntax highlighting

Reviewers: cullmann, dhaumann

Reviewed By: cullmann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D19533

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-12-30 Thread Kåre Särs
https://bugs.kde.org/show_bug.cgi?id=401480

Kåre Särs  changed:

   What|Removed |Added

 CC||martial.g...@mutech.ch

--- Comment #11 from Kåre Särs  ---
*** Bug 401162 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-12-21 Thread Kåre Särs
https://bugs.kde.org/show_bug.cgi?id=401480

Kåre Särs  changed:

   What|Removed |Added

 CC||killerm...@yahoo.com

--- Comment #10 from Kåre Särs  ---
*** Bug 402421 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-12-16 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=401480

--- Comment #9 from Dominik Haumann  ---
Btw, adding this file to KSyntaxHighlighting, the syntax highlighting indexer
says:

Error FODC0002 in
file:///home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/arduino.xml,
at line 287, column 78: Entity 'separators' not declared.

--> KSyntaxHighlighting should somehow reject this file entirely when not
compiled in as resource.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-12-16 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=401480

--- Comment #8 from Dominik Haumann  ---
Ok, that means it's missing the entities such as  and .
Imo KSyntaxHighlighting should reject these files somehow... But that's tricky
with lazy loading...

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-12-16 Thread Kåre Särs
https://bugs.kde.org/show_bug.cgi?id=401480

--- Comment #7 from Kåre Särs  ---
PS.

Adding the  tag from isocpp.xml to the Arduino HL file also stops the
crash, but there are still a bunch of debug warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-12-16 Thread Kåre Särs
https://bugs.kde.org/show_bug.cgi?id=401480

Kåre Särs  changed:

   What|Removed |Added

 CC||kare.s...@iki.fi

--- Comment #6 from Kåre Särs  ---
I also get a crash with this arduino highlight file.

I get the crash from an Q_ASSERT(format.isValid()) in
KateHighlighting::applyFormat(...)

replacing the assert with an early return stops the crash, but there is no
highlighting and a lot of debug messages about the broken HL file. 

As expected not returning early also results in a crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-12-15 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=401480

--- Comment #5 from Dominik Haumann  ---
This needs investigation, since if such a setup crashes KSyntaxHighlighting,
possibly many users might hit this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-11-28 Thread Martial Guex
https://bugs.kde.org/show_bug.cgi?id=401480

--- Comment #4 from Martial Guex  ---
Oops -:(

I found the same custom highlight file for arduino on two folders ~ / .kde /
share / apps / katepart / syntax / and / usr / share / katepart5 / syntax /.

I deleted files and the problem is gone.

I attached this file to check on your side.

Inadvertently I joined the same file twice to improve the definition so if you
have a way to remove one, I did not find a way to do it.

Sorry for the inconvenience to everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-11-28 Thread Martial Guex
https://bugs.kde.org/show_bug.cgi?id=401480

--- Comment #3 from Martial Guex  ---
Created attachment 116549
  --> https://bugs.kde.org/attachment.cgi?id=116549=edit
Custom file for syntax highlight for arduino, it's generate an kate crash
(memory protect)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-11-28 Thread Martial Guex
https://bugs.kde.org/show_bug.cgi?id=401480

--- Comment #2 from Martial Guex  ---
Created attachment 116548
  --> https://bugs.kde.org/attachment.cgi?id=116548=edit
Custom syntax highlight for arduino making kate crash (memory protect)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-11-28 Thread Thomas Surrel
https://bugs.kde.org/show_bug.cgi?id=401480

Thomas Surrel  changed:

   What|Removed |Added

 CC||thomas.sur...@protonmail.co
   ||m

--- Comment #1 from Thomas Surrel  ---
The example file you pointed to works fine for me in Kate and Kwrite. What
synthax highlighting is active when opening the file ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 401480] SIGSEGV, Segmentation fault on open aduino file *.ino & kwrite et kate

2018-11-27 Thread Martial Guex
https://bugs.kde.org/show_bug.cgi?id=401480

Martial Guex  changed:

   What|Removed |Added

Summary|SIGSEGV, Segmentation fault |SIGSEGV, Segmentation fault
   |on open aduino file *.ino   |on open aduino file *.ino &
   |on kwrite et kate   |kwrite et kate

-- 
You are receiving this mail because:
You are watching all bug changes.