[juk] [Bug 381271] Paused music started playing on suspend

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=381271

--- Comment #7 from Michael D  ---
Thanks again!

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 381271] Paused music started playing on suspend

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=381271

Michael Pyne  changed:

   What|Removed |Added

   Version Fixed In||18.04
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/juk
   ||/57457aee76ec28a3ed590ff559
   ||da60b353864ad6

--- Comment #6 from Michael Pyne  ---
Git commit 57457aee76ec28a3ed590ff559da60b353864ad6 by Michael Pyne.
Committed on 06/03/2018 at 02:54.
Pushed by mpyne into branch 'master'.

mpris: Don't toggle playback with "Pause".

We already have a separate playPause action for this, both in the MPRIS2
DBus adaptor, and in PlayerManager.

This also fixes playback resuming when the computer is suspended (Plasma
sends the "Pause" command to each media player regardless of whether
it's playing, and JuK incorrectly treats that as a request to toggle
playback).
FIXED-IN:18.04

M  +1-6playermanager.cpp

https://commits.kde.org/juk/57457aee76ec28a3ed590ff559da60b353864ad6

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 381271] Paused music started playing on suspend

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=381271

--- Comment #5 from Michael Pyne  ---
Now that you mention it, it didn't make it into any version of JuK because I
never got feedback so I forgot about this one. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 381271] Paused music started playing on suspend

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=381271

Michael D  changed:

   What|Removed |Added

 CC||nortex...@gmail.com

--- Comment #4 from Michael D  ---
The fix seems not to have made its way into version 17.12.2 which resumes play
on resume from suspend.

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 381271] Paused music started playing on suspend

[Jose Couto]

https://bugs.kde.org/show_bug.cgi?id=381271

Jose Couto  changed:

   What|Removed |Added

 CC||coque.co...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 381271] Paused music started playing on suspend

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=381271

Michael Pyne  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #3 from Michael Pyne  ---
The following patch should fix.  I'd commit directly but I don't have a KDE 4
dev environment setup, so if someone can test that this work I'd appreciate it,
otherwise I can establish one overnight and try again in a bit.

(Yes, I know I need to port JuK to KF5... right now I'm going to try for a
mini-sprint in mid-July for this)

diff --git a/playermanager.cpp b/playermanager.cpp
index 6ca08e0..3a2e091 100644
--- a/playermanager.cpp
+++ b/playermanager.cpp
@@ -276,11 +276,7 @@ void PlayerManager::play()

 void PlayerManager::pause()
 {
-if(!m_setup)
-return;
-
-if(paused()) {
-play();
+if(!m_setup || paused()) {
 return;
 }

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 381271] Paused music started playing on suspend

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381271

Nate Graham  changed:

   What|Removed |Added

Summary|Music started on suspend|Paused music started
   ||playing on suspend

-- 
You are receiving this mail because:
You are watching all bug changes.