[juk] [Bug 388663] Juk crashes on quit

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=388663

--- Comment #7 from Michael D  ---
Great, and thanks a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 388663] Juk crashes on quit

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=388663

Michael Pyne  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/juk
   ||/a951caf3e9dd54f56fa1a32d4d
   ||c8bbbdfc269252
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||18.04

--- Comment #6 from Michael Pyne  ---
Git commit a951caf3e9dd54f56fa1a32d4dc8bbbdfc269252 by Michael Pyne.
Committed on 25/03/2018 at 19:44.
Pushed by mpyne into branch 'master'.

Simplify shutdown handling.

JuK would fail to shutdown properly under Plasma 5 when the system tray
was disabled and you used the 'X' from the window manager title bar to
try to close JuK.  May have failed under other WMs or desktops as well,
I haven't tested that.

The shutdown code hasn't been reworked since KDE 3 times and for all I
know I introduced this bug with the setQuitOnLastWindowClosed setting in
main.cpp years ago and never realized.

But this way, any way you destroy the main application class (JuK), you
end up shutting down.  Continuing to use setQuitOnLastWindowClosed
appears to be necessary since Qt will remove the queued quit signal to
qApp once JuK is destructed and I don't trust running qApp->quit within
the JuK dtor itself.

Hopefully this fixes a crash-on-quit bug, but if not just reopen and
I'll figure it out somehow...

FIXED-IN:18.04

M  +35   -32   juk.cpp
M  +0-1juk.h
M  +0-6main.cpp

https://commits.kde.org/juk/a951caf3e9dd54f56fa1a32d4dc8bbbdfc269252

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 388663] Juk crashes on quit

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=388663

--- Comment #5 from Michael D  ---
...and NOT when I use the menu (e.g. ctrl+q).

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 388663] Juk crashes on quit

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=388663

--- Comment #4 from Michael D  ---
I should mention that this only happens for me when I click the title bar close
button on window decoration, and when I exit using ctrl + q (or from the menu).

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 388663] Juk crashes on quit

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=388663

--- Comment #3 from Michael D  ---
Created attachment 111584
  --> https://bugs.kde.org/attachment.cgi?id=111584=edit
Backtrace from drkonqi

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 388663] Juk crashes on quit

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=388663

--- Comment #2 from Michael D  ---
I would like to help further, but I don't really know how to compile
applications from source, and I don't have the relevant development packages
installed (and don't even know what they are). Sorry! Do let me know if I can
help otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 388663] Juk crashes on quit

[Michael Pyne]

https://bugs.kde.org/show_bug.cgi?id=388663

--- Comment #1 from Michael Pyne  ---
I see the normal crash on exit bugs got ported to KF5 as well. :(

Is it possible to compile JuK with debugging support enabled to get a good
backtrace?  It's hard to tell what's happening here other than some kind of
libmad error.

-- 
You are receiving this mail because:
You are watching all bug changes.