[juk] [Bug 389130] Track Sorting

2018-02-10 Thread Michael Pyne 
https://bugs.kde.org/show_bug.cgi?id=389130

Michael Pyne  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/juk |https://commits.kde.org/juk
   |/81c0dcc278a9c17fb96e0b41ab |/cd8e92003e0bf4806af3d8bb8d
   |34bc32fb2c289e  |7a1fba7ea5cdb7

--- Comment #3 from Michael Pyne  ---
Git commit cd8e92003e0bf4806af3d8bb8d7a1fba7ea5cdb7 by Michael Pyne, on behalf
of Kacper Kasper.
Committed on 10/02/2018 at 22:47.
Pushed by mpyne into branch 'Applications/17.12'.

Fix columns sorting.

Summary:
QTreeWidgetItem in Qt5 requires overloading < operator to implement
custom sorting. Use existing compare methods to do that.

Additionally, natural sorting was implemented for strings.
This allows to sort by filenames like file_.

Test Plan:
Click on columns to sort them.
Columns are sorted by artist, album and track number.

Reviewers: mpyne

Differential Revision: https://phabricator.kde.org/D10130

M  +24   -8playlistitem.cpp
M  +3-1playlistitem.h

https://commits.kde.org/juk/cd8e92003e0bf4806af3d8bb8d7a1fba7ea5cdb7

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 389130] Track Sorting

2018-01-28 Thread Kacper Kasper 
https://bugs.kde.org/show_bug.cgi?id=389130

Kacper Kasper  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/juk
   ||/81c0dcc278a9c17fb96e0b41ab
   ||34bc32fb2c289e
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Kacper Kasper  ---
Git commit 81c0dcc278a9c17fb96e0b41ab34bc32fb2c289e by Kacper Kasper.
Committed on 28/01/2018 at 14:13.
Pushed by kkasper into branch 'master'.

Fix columns sorting.

Summary:
QTreeWidgetItem in Qt5 requires overloading < operator to implement
custom sorting. Use existing compare methods to do that.

Additionally, natural sorting was implemented for strings.
This allows to sort by filenames like file_.

Test Plan:
Click on columns to sort them.
Columns are sorted by artist, album and track number.

Reviewers: mpyne

Differential Revision: https://phabricator.kde.org/D10130

M  +24   -8playlistitem.cpp
M  +3-1playlistitem.h

https://commits.kde.org/juk/81c0dcc278a9c17fb96e0b41ab34bc32fb2c289e

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 389130] Track Sorting

2018-01-26 Thread Kacper Kasper 
https://bugs.kde.org/show_bug.cgi?id=389130

Kacper Kasper  changed:

   What|Removed |Added

 CC||kacperkas...@gmail.com
   Assignee|whee...@kde.org |kacperkas...@gmail.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

--- Comment #1 from Kacper Kasper  ---
I have local changes that fix this.

-- 
You are receiving this mail because:
You are watching all bug changes.