[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=375125

Dr. Chapatin  changed:

   What|Removed |Added

Version|18.04.0 |18.08.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=375125

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=375125

Dr. Chapatin  changed:

   What|Removed |Added

Version|unspecified |18.04.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=375125

--- Comment #7 from Leslie Zhai  ---
(In reply to Leslie Zhai from comment #6)
> (In reply to Pino Toscano from comment #5)
> > I do not think this is a correct fix.  Now the config dialog has a fixed
> > size, and cannot be resized at all: this is bad for usability, since it
> > truncates labels of checkboxes, texts in list views, and so on.
> > 
> > I reverted it, and thus reopened this bug.
> 
> Sorry for my dirty patch...

I think it is better to code review firstly, if LGTM by Pino, then I git push
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=375125

Leslie Zhai  changed:

   What|Removed |Added

 CC||lesliez...@llvm.org.cn

--- Comment #6 from Leslie Zhai  ---
(In reply to Pino Toscano from comment #5)
> I do not think this is a correct fix.  Now the config dialog has a fixed
> size, and cannot be resized at all: this is bad for usability, since it
> truncates labels of checkboxes, texts in list views, and so on.
> 
> I reverted it, and thus reopened this bug.

Sorry for my dirty patch...

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=375125

Pino Toscano  changed:

   What|Removed |Added

 CC||p...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=375125

Pino Toscano  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #5 from Pino Toscano  ---
I do not think this is a correct fix.  Now the config dialog has a fixed size,
and cannot be resized at all: this is bad for usability, since it truncates
labels of checkboxes, texts in list views, and so on.

I reverted it, and thus reopened this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=375125

Leslie Zhai  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/k3b
   ||/828891b2cbba66f85038056461
   ||93728901e40af4

--- Comment #4 from Leslie Zhai  ---
Git commit 828891b2cbba66f8503805646193728901e40af4 by Leslie Zhai.
Committed on 14/03/2017 at 08:01.
Pushed by lesliezhai into branch 'master'.

Fix Settings dialog resizes itself issue

M  +1-1src/option/k3boptiondialog.cpp

https://commits.kde.org/k3b/828891b2cbba66f8503805646193728901e40af4

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=375125

--- Comment #3 from Burkhard Lueck  ---
On your screencast I see the issue now and it is reproducible here

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=375125

Dr. Chapatin  changed:

   What|Removed |Added

  Component|Data Project|GUI/Usability

--- Comment #2 from Dr. Chapatin  ---
Sorry, I have changed to the correct component.

I'm running k3b 17.04, kde frameworks 5.29, Qt 5.8 (built against 5.7.1)

I recorded a screencast
https://www.youtube.com/watch?v=BPwI0SBOHxg

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=375125

Burkhard Lueck  changed:

   What|Removed |Added

 CC||lu...@hube-lueck.de

--- Comment #1 from Burkhard Lueck  ---
k3b build from sources 
Version 17.04.00
KDE Frameworks 5.31.0
Qt 5.6.1 (built against 5.6.1)
not reproducible for me

What are your versions?
Why did you select component "Data Project"? I see no relation to this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.