[k3b] [Bug 382775] Settings window has no "cancel" button

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=382775

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 382775] Settings window has no "cancel" button

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=382775

--- Comment #6 from Leslie Zhai  ---
(In reply to Pino Toscano from comment #5)
> It is fixed in k3b >= 17.11.80.

Hi Pino,

Could you review my code as a Reviewer? It is better to double check my work in
future for BUG FREE :) thanks a lot!

Regards,
Leslie Zhai -a LLVM developer https://reviews.llvm.org/p/xiangzhai/

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 382775] Settings window has no "cancel" button

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=382775

Pino Toscano  changed:

   What|Removed |Added

   Version Fixed In||17.11.80

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 382775] Settings window has no "cancel" button

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=382775

Pino Toscano  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Pino Toscano  ---
It is fixed in k3b >= 17.11.80.

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 382775] Settings window has no "cancel" button

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=382775

Dr. Chapatin  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #4 from Dr. Chapatin  ---
not fixed in k3b 17.08.

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 382775] Settings window has no "cancel" button

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=382775

Leslie Zhai  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/k3b
   ||/e5eb0a786287ac7d647e391ae7
   ||987bc89402b35c
 Resolution|INVALID |FIXED

--- Comment #3 from Leslie Zhai  ---
Git commit e5eb0a786287ac7d647e391ae7987bc89402b35c by Leslie Zhai.
Committed on 28/07/2017 at 01:37.
Pushed by lesliezhai into branch 'master'.

Add cancel button for K3b::OptionDialog AKA Settings window.

M  +1-1src/option/k3boptiondialog.cpp

https://commits.kde.org/k3b/e5eb0a786287ac7d647e391ae7987bc89402b35c

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 382775] Settings window has no "cancel" button

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=382775

--- Comment #2 from Dr. Chapatin  ---
Many kde apps have both cancel and close buttons: dolphin, konsole, ark, kate,
okular, gwenview, ktorrent.
I think missing close button in K3b settings is not something consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 382775] Settings window has no "cancel" button

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=382775

Leslie Zhai  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||lesliez...@llvm.org.cn
 Resolution|--- |INVALID

--- Comment #1 from Leslie Zhai  ---
just click the close button :)

-- 
You are receiving this mail because:
You are watching all bug changes.