[kaffeine] [Bug 398952] Channels icon mess in kaffeine 2.0.x

2019-05-03 Thread Mauro Carvalho Chehab
https://bugs.kde.org/show_bug.cgi?id=398952

Mauro Carvalho Chehab  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|REPORTED|RESOLVED

--- Comment #2 from Mauro Carvalho Chehab  ---
As this is working for me, I suspect that this is an issue at either the icon
set setup at Plasma, or the broadcaster is not providing information about
encrypted channels via the usual descriptor. 

As, on either case, there's not much we can do at Kaffeine's side, I'm closing
this. If you belive it is a mistake, feel free to re-open, providing additional
information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 398952] Channels icon mess in kaffeine 2.0.x

2018-11-05 Thread Mauro Carvalho Chehab
https://bugs.kde.org/show_bug.cgi?id=398952

--- Comment #1 from Mauro Carvalho Chehab  ---
(In reply to knossos456 from comment #0)
> Since Kaffeine 2.0.x, the icons concerning radio and television (fta and
> scrambled) in source directory icons are not applied .
> 
> There is no more possiblility to remember graphicaly if the programm is
> srcrambled or not in channel list without right click -> edit channel...
> 
> When we use a CI Cam and have no decryption of programm, we need this
> information without lot of manipulations ...
> There is no MMI implemented, i know this is a big part to code... but exist
> in most windows DVB softwares. I can contribute for this but only for debug.
> I'm not a expert in Kde/QT programming.
> 
> This is a big mess to debug this part of Kde, i need help.
> 
> Same problem under Ubuntu 18 and 16.

In thesis, this should be working. The check if a channel is FTA or not is done
at src/dvb/dvbscandialog.cpp:

if (channel.hasVideo) {
if (!channel.isScrambled) {
return
QIcon::fromTheme(QLatin1String("video-television"),
QIcon(":video-television"));
} else {
return
QIcon::fromTheme(QLatin1String("video-television-encrypted"),
QIcon(":video-television-encrypted"));
}
} else {
if (!channel.isScrambled) {
return
QIcon::fromTheme(QLatin1String("text-speak"), QIcon(":text-speak"));
} else {
return
QIcon::fromTheme(QLatin1String("audio-radio-encrypted"),
QIcon(":audio-radio-encrypted"));
}
}

It should be noticed that Kaffeine doesn't actually check if a channel is FTA
or not. Instead, it uses the descriptor. So, for DVB standards, it will use the
DVB SDT table, as described at tools/dvbsi.xml:


  
  
  
  
  
  
  
  


I've seen cases of some DVB-C networks that mess with this bit, not setting it
right.

-- 
You are receiving this mail because:
You are watching all bug changes.