[kasts] [Bug 457848] Offer better filenames for saved podcasts
https://bugs.kde.org/show_bug.cgi?id=457848 --- Comment #6 from tob...@g3ro.eu --- Also thank you for this fix. I got only one addional request for this: Maybe you could add an episode number and or date to the episode name. -- You are receiving this mail because: You are watching all bug changes.
[kasts] [Bug 457848] Offer better filenames for saved podcasts
https://bugs.kde.org/show_bug.cgi?id=457848 b...@mogwai.be changed: What|Removed |Added Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult |imedia/kasts/-/commit/dc311 |imedia/kasts/-/commit/2068b |cac7b65c0b3ee9c2be1faac0c9b |0515f6e78f50ff0c874aaa9bc1d |ed04596f|a4aae124 --- Comment #5 from b...@mogwai.be --- Git commit 2068b0515f6e78f50ff0c874aaa9bc1da4aae124 by Bart De Vries, on behalf of Eamonn Rea. Committed on 18/07/2023 at 17:06. Pushed by bdevries into branch 'release/23.08'. Use Entry title to set downloaded file name Instead of using the MD5 hash of the enclosure download URL, we create a filename which follows `feedname/entry_title.hash.ext`, where feedname is a uniquefied feed title (stored in the DB), a truncated version of the entry title, a shortened hash based on the download URL, and the original file extension extracted from the download URL. M +83 -0src/database.cpp M +1-0src/database.h M +38 -30 src/datamanager.cpp M +2-2src/enclosure.cpp M +14 -0src/feed.cpp M +5-0src/feed.h M +2-1src/fetcher.h M +33 -7src/storagemanager.cpp M +4-1src/storagemanager.h M +7-0src/storagemovejob.cpp M +76 -12 src/updatefeedjob.cpp M +5-2src/updatefeedjob.h https://invent.kde.org/multimedia/kasts/-/commit/2068b0515f6e78f50ff0c874aaa9bc1da4aae124 -- You are receiving this mail because: You are watching all bug changes.
[kasts] [Bug 457848] Offer better filenames for saved podcasts
https://bugs.kde.org/show_bug.cgi?id=457848 b...@mogwai.be changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/mult ||imedia/kasts/-/commit/dc311 ||cac7b65c0b3ee9c2be1faac0c9b ||ed04596f --- Comment #4 from b...@mogwai.be --- Git commit dc311cac7b65c0b3ee9c2be1faac0c9bed04596f by Bart De Vries, on behalf of Eamonn Rea. Committed on 17/07/2023 at 12:52. Pushed by bdevries into branch 'master'. Use Entry title to set downloaded file name Instead of using the MD5 hash of the enclosure download URL, we create a filename which follows `feedname/entry_title.hash.ext`, where feedname is a uniquefied feed title (stored in the DB), a truncated version of the entry title, a shortened hash based on the download URL, and the original file extension extracted from the download URL. M +83 -0src/database.cpp M +1-0src/database.h M +38 -30 src/datamanager.cpp M +2-2src/enclosure.cpp M +14 -0src/feed.cpp M +5-0src/feed.h M +2-1src/fetcher.h M +33 -7src/storagemanager.cpp M +4-1src/storagemanager.h M +7-0src/storagemovejob.cpp M +76 -12 src/updatefeedjob.cpp M +5-2src/updatefeedjob.h https://invent.kde.org/multimedia/kasts/-/commit/dc311cac7b65c0b3ee9c2be1faac0c9bed04596f -- You are receiving this mail because: You are watching all bug changes.
[kasts] [Bug 457848] Offer better filenames for saved podcasts
https://bugs.kde.org/show_bug.cgi?id=457848 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kasts/-/merge_requests/116 -- You are receiving this mail because: You are watching all bug changes.
[kasts] [Bug 457848] Offer better filenames for saved podcasts
https://bugs.kde.org/show_bug.cgi?id=457848 --- Comment #2 from tob...@g3ro.eu --- (In reply to bart from comment #1) > Thanks for reporting. > > I will see what can be done there. The huge advantage of the current > hash-based filenames is that there are no worries whatsoever about invalid > characters in filenames. If the podcast and/or episode titles are used, > then you can get into nasty territory concerning i18n and underlying > filesystems not supporting certain characters. Ok, I understand. I just had a "crazy" idea: What about creating symbolic links? We could have a seperate folder (e.g. called "podcasts-named") and the program would create symbolic links with the filename "structure" I suggested (podcastshow-ep104.mp3) and link to the hashed ones. This way the program could still use the hashes and work properly in any situation. -- You are receiving this mail because: You are watching all bug changes.
[kasts] [Bug 457848] Offer better filenames for saved podcasts
https://bugs.kde.org/show_bug.cgi?id=457848 b...@mogwai.be changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from b...@mogwai.be --- Thanks for reporting. I will see what can be done there. The huge advantage of the current hash-based filenames is that there are no worries whatsoever about invalid characters in filenames. If the podcast and/or episode titles are used, then you can get into nasty territory concerning i18n and underlying filesystems not supporting certain characters. -- You are receiving this mail because: You are watching all bug changes.
