[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-08-24 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=408418

Christoph Cullmann  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Christoph Cullmann  ---
;=) As confusing this is, the call for CTRL-G is "external", too.
For me it properly centerse again for that action, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-08-01 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=408418

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #6 from Albert Astals Cid  ---
Hmm, you only decided to forcecenter for external calls.

But this is about Ctrl+G

This is not an external call, is it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-07-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408418

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.61

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-07-07 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=408418

Christoph Cullmann  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kte
   ||xteditor/49b8add426a252afc1
   ||976188baebde194d75ced2
 Resolution|--- |FIXED

--- Comment #5 from Christoph Cullmann  ---
Git commit 49b8add426a252afc1976188baebde194d75ced2 by Christoph Cullmann.
Committed on 07/07/2019 at 12:04.
Pushed by cullmann into branch 'master'.

fix goto line centering
force center for any external set cursor position call

M  +1-1src/view/kateview.cpp

https://commits.kde.org/ktexteditor/49b8add426a252afc1976188baebde194d75ced2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-07-07 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=408418

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #4 from Christoph Cullmann  ---
I guess, as nobody seems to have time, perhaps partial revert is a good idea.
Which commit was it exactly?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-07-07 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=408418

--- Comment #3 from Ahmad Samir  ---
Ping.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-06-19 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=408418

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
IMHO, the change in updateCursor(), should be reverted; and if there's a use
case where that behaviour isn't wanted, then we can make setCursorPosition()
and setCursorPositionInternal() have an extra boolean parameter - that's true
by default - to center the cursor line in the view; that means any caller that
doesn't want that bevhaviour can easily opt-out, a case by case treatment...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-06-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408418

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability
   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-06-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408418

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 408418] New "go to line" behaviour is less useful than before

2019-06-07 Thread Lothar
https://bugs.kde.org/show_bug.cgi?id=408418

Lothar  changed:

   What|Removed |Added

 CC||loh@googlemail.com

--- Comment #1 from Lothar  ---
I notice also such less optimal behavior and guess it's caused by this one:
https://phabricator.kde.org/D17857#425268 (now it's line 1493, not 63)

But just to revert this isn't a proper fix. Perhaps should there some special
function for such "goto" action with a better centering to the screen. I guess
it's not only an issue of these explicit "Goto Line" action but also when jump
to e.g. next search result.

-- 
You are receiving this mail because:
You are watching all bug changes.