[kcalc] [Bug 57349] Wrong behaviour on repeated pressing operator buttons

2018-10-05 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=57349

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kca
   ||lc/b0ce4ff01b5e1f7f4c2340b9
   ||0f326491437c076c

--- Comment #23 from Albert Astals Cid  ---
Git commit b0ce4ff01b5e1f7f4c2340b90f326491437c076c by Albert Astals Cid, on
behalf of Maximilian Schiller.
Committed on 05/10/2018 at 21:09.
Pushed by aacid into branch 'master'.

Corrected behaviour on repeated pressing of operator buttons

Summary:
Fixes "wrong" behavior to the correct one as described in the bug report.
Before the fix pressing "10 * / 5 =" normally would result in 20 (Stack:
(10,*), (10,/), (5,=)) but with those changes it results in 2 (Stack: (10, /),
(5, =)).

Internally this is achieved by "blocking" node adding after a operator
(*,-,/,...) has been pressed until a number is entered. If another operator is
pressed whilst blocked the top (last) operator is changed instead.

Reviewers: cfeck, teran, #kde_applications

Reviewed By: cfeck

Subscribers: aacid, cfeck, kde-utils-devel

Differential Revision: https://phabricator.kde.org/D15463

M  +3-1kcalc.cpp
M  +17   -3kcalc_core.cpp
M  +3-0kcalc_core.h

https://commits.kde.org/kcalc/b0ce4ff01b5e1f7f4c2340b90f326491437c076c

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 57349] Wrong behaviour on repeated pressing operator buttons

2018-02-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=57349

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.