[kdeconnect] [Bug 345015] No coverart of the currently playing media in the MPRIS plug-in

[Matthijs Tijink]

https://bugs.kde.org/show_bug.cgi?id=345015

Matthijs Tijink  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kde
   ||connect-android/0d00b8aa4ac
   ||3f88485797e09950b713483273f
   ||63
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Matthijs Tijink  ---
Git commit 0d00b8aa4ac3f88485797e09950b713483273f63 by Matthijs Tijink.
Committed on 24/02/2018 at 15:21.
Pushed by mtijink into branch 'master'.

Add album cover art support.

Summary:
Fetches http(s) album art urls, as supplied by MPRIS, to display as album art.
Fetched urls and failed fetches are cached to prevent unneccessary network
activity.

The bulk of the code is in the fetching+caching class `AlbumArtCache`.

Takes the comments from d52be10 into account:
 - The images (HTTP(S) only for now) are cached. This is limited to 5 MB on
disk or 10 entries in memory.
 - The image gets viewing space depending on the remaining screen space. Thus,
controls should never be pushed off-screen.
 - "Edge cases" like going from cover art to no cover art is handled correctly
(actually a result of earlier mpris code changes).

Additionally, it adds a landscape mode to the MPRIS activity, which shows the
cover art and controls side by side.

Desktop part is in D9563.

Test Plan: Works both with/without album art. Switching players and tracks
correctly changes the album art.

Reviewers: #kde_connect, #vdg, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, ngraham, nicolasfella, apol

Differential Revision: https://phabricator.kde.org/D9564

M  +1-0build.gradle
A  +9-0res/drawable/ic_album_art_placeholder.xml
A  +26   -0res/layout-land/activity_mpris.xml
A  +25   -0res/layout/activity_mpris.xml
M  +1-4res/layout/mpris_control.xml
A  +428  -0src/org/kde/kdeconnect/Plugins/MprisPlugin/AlbumArtCache.java
M  +14   -1src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java
M  +46   -0src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java

https://commits.kde.org/kdeconnect-android/0d00b8aa4ac3f88485797e09950b713483273f63

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 345015] No coverart of the currently playing media in the MPRIS plug-in

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=345015

--- Comment #1 from Aleix Pol  ---
See https://phabricator.kde.org/D9564

-- 
You are receiving this mail because:
You are watching all bug changes.