[kdeconnect] [Bug 392853] Ring phone doesen't actually ring phone

[Matthijs Tijink]

https://bugs.kde.org/show_bug.cgi?id=392853

Matthijs Tijink  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kde
   ||connect-android/2cd7d4b7a99
   ||aa0073e1a29627b5b10628fa840
   ||fd
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Matthijs Tijink  ---
Git commit 2cd7d4b7a99aa0073e1a29627b5b10628fa840fd by Matthijs Tijink.
Committed on 09/04/2018 at 17:00.
Pushed by mtijink into branch 'master'.

Fix default Find My Phone ringtone

Summary:
Previously, if the user hadn't set a ringtone, the code raised an exception
(because an empty string isn't an uri). Thus, no sound was played.

This fixes it.

Test Plan: Without having set a ringtone, it works. Otherwise, it works too.

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: nicolasfella, sredman, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12070

M  +9-2   
src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java

https://commits.kde.org/kdeconnect-android/2cd7d4b7a99aa0073e1a29627b5b10628fa840fd

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 392853] Ring phone doesen't actually ring phone

[Matthijs Tijink]

https://bugs.kde.org/show_bug.cgi?id=392853

Matthijs Tijink  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
Version|unspecified |1.8

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 392853] Ring phone doesen't actually ring phone

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=392853

--- Comment #2 from Zakhar  ---
Alarm volume = max
alarm ringtone = default

phone is Android 7.0, kdeconnect-1.2.1-r2 on pc

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 392853] Ring phone doesen't actually ring phone

[Matthijs Tijink]

https://bugs.kde.org/show_bug.cgi?id=392853

Matthijs Tijink  changed:

   What|Removed |Added

 CC||matthijstij...@gmail.com

--- Comment #1 from Matthijs Tijink  ---
Hmm weird. Can you specify your KDE Connect version (on Android)?

Could you specify some of your settings?
 - Alarm volume (and try if changing it helps)
 - Alarm ringtone

-- 
You are receiving this mail because:
You are watching all bug changes.