[kdeconnect] [Bug 427717] KDEConnect crush on notification

2020-10-19 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=427717

Nicolas Fella  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/knotifications/commi
   ||t/c58ac88593e2e4d8cb7137d78
   ||7fdbc0269dd7e36
 Resolution|--- |FIXED

--- Comment #7 from Nicolas Fella  ---
Git commit c58ac88593e2e4d8cb7137d787fdbc0269dd7e36 by Nicolas Fella.
Committed on 15/10/2020 at 20:43.
Pushed by nicolasfella into branch 'master'.

Apply some sanity checking to action keys

In case the notification server sends invalid actions don't forward them to the
application.

For example LXDE sends ActionInvoked for the default action even when no
default action has been declared.

M  +9-2src/notifybypopup.cpp

https://invent.kde.org/frameworks/knotifications/commit/c58ac88593e2e4d8cb7137d787fdbc0269dd7e36

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 427717] KDEConnect crush on notification

2020-10-15 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=427717

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/knotifications/-/merge_requests/13

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 427717] KDEConnect crush on notification

2020-10-15 Thread Misha
https://bugs.kde.org/show_bug.cgi?id=427717

--- Comment #5 from Misha  ---
Thank you very much for fixing!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 427717] KDEConnect crush on notification

2020-10-15 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=427717

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/333

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 427717] KDEConnect crush on notification

2020-10-15 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=427717

--- Comment #3 from Nicolas Fella  ---
Thanks!

I was able to reproduce the problem in a Fedora LXDE VM and it seems to match
my suspicion. There seems to be some difference in how the notifications are
implemented in Plasma and LXDE which is why I haven't experienced the problem
on Plasma. It should be easy to fix though

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 427717] KDEConnect crush on notification

2020-10-15 Thread Misha
https://bugs.kde.org/show_bug.cgi?id=427717

--- Comment #2 from Misha  ---
(In reply to Nicolas Fella from comment #1)
> Judging by the backtrace you clicked on the notification before it crashed.
> Do you remember if you clicked on a specific action or just the notification
> itself?
> 
> Also, what desktop are you using?
> 
> I have an idea what is going on, but I haven't tried to reproduce it yet

Just clicked on the notification from Telegram
I'm using Fedora 32 with LXDE desktop

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 427717] KDEConnect crush on notification

2020-10-14 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=427717

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #1 from Nicolas Fella  ---
Judging by the backtrace you clicked on the notification before it crashed. Do
you remember if you clicked on a specific action or just the notification
itself?

Also, what desktop are you using?

I have an idea what is going on, but I haven't tried to reproduce it yet

-- 
You are receiving this mail because:
You are watching all bug changes.