[kdenetwork-filesharing] [Bug 334618] Samba sharing errors are not displayed in the UI
https://bugs.kde.org/show_bug.cgi?id=334618 Harald Sitter changed: What|Removed |Added Latest Commit||https://invent.kde.org/netw ||ork/kdenetwork-filesharing/ ||commit/01a6bda31bbc32d54bef ||49111765aabbb771d153 Version Fixed In||20.12 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Harald Sitter --- Git commit 01a6bda31bbc32d54bef49111765aabbb771d153 by Harald Sitter. Committed on 12/08/2020 at 14:37. Pushed by sitter into branch 'master'. give add/remove errors a GUI previously we'd ignore the returned errors leaving the user hanging when adding a share fails and not even telling them why. we now route errors on add/remove through somewhat generic kmessagebox-based reporting tech. unfortunately this is fairly excessive WRT string mapping because ksambashare sports one enum for everything so API-wise a call to save() could return UserShareAclOk but in practice that of course cannot happen because that'd mean nothing. as such many of the strings are overly generic because they cannot practically appear on weak context actions like save(). very meh. this depends on the new lastSystemErrorString() API in KIO to stringify the majority of failure scenarios here, which come out of samba's 'net' command trying to share /tmp now produces a kmessagebox informing the user that the dir cannot be shared FIXED-IN: 20.12 M +1-1CMakeLists.txt M +90 -3samba/filepropertiesplugin/sambausershareplugin.cpp M +4-0samba/filepropertiesplugin/sambausershareplugin.h https://invent.kde.org/network/kdenetwork-filesharing/commit/01a6bda31bbc32d54bef49111765aabbb771d153 -- You are receiving this mail because: You are watching all bug changes.
[kdenetwork-filesharing] [Bug 334618] Samba sharing errors are not displayed in the UI
https://bugs.kde.org/show_bug.cgi?id=334618 --- Comment #6 from Harald Sitter --- Git commit 5e1571cf2909d026f781dfaa978ab10705d30d8d by Harald Sitter. Committed on 12/08/2020 at 09:32. Pushed by sitter into branch 'master'. smb: keep stderr of net commands on add/remove this allows guis to show the backend stderr on UserShareSystemError when we haven't managed to map that to a more specific type (which we currently do not ever; there's an unresolved todo about this). M +34 -14 src/core/ksambashare.cpp M +11 -0src/core/ksambashare.h M +2-1src/core/ksambashare_p.h M +3-3src/core/ksambasharedata.h https://invent.kde.org/frameworks/kio/commit/5e1571cf2909d026f781dfaa978ab10705d30d8d -- You are receiving this mail because: You are watching all bug changes.
[kdenetwork-filesharing] [Bug 334618] Samba sharing errors are not displayed in the UI
https://bugs.kde.org/show_bug.cgi?id=334618 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/network/kdenetwork-filesharing/-/merge_requests/2 -- You are receiving this mail because: You are watching all bug changes.
[kdenetwork-filesharing] [Bug 334618] Samba sharing errors are not displayed in the UI
https://bugs.kde.org/show_bug.cgi?id=334618 --- Comment #4 from Harald Sitter --- I spoke too soon. There's half a localization infrastructure in samba and as a result the net command is in fact not localized ... At the same time this could change at any point so modeling net command errors as part of the public api of ksambashare is also out of the question. So, I guess that leaves us with a kind of inbetween. KSambaShare should grow an errorString() that is set when a command returns a SystemError, the errorString in turn is either parsed from the net stderr and then localized on our end or the verbatim (unlocalized) stderr if we cannot identify the error reported in stderr through parsing. A bit meh -- You are receiving this mail because: You are watching all bug changes.
[kdenetwork-filesharing] [Bug 334618] Samba sharing errors are not displayed in the UI
https://bugs.kde.org/show_bug.cgi?id=334618 Harald Sitter changed: What|Removed |Added CC||sit...@kde.org --- Comment #3 from Harald Sitter --- For the record: the best we can do here is forward the error message if exit code !=0. The output from net usershare (net_usershare.c) has utterly arbitrary format. Fortunately it is also fully i18n'd, so simply forwarding the output is likely perfectly reasonable as it will be a l10n'd pretty string anyway. The swaths of text may require us to use KMessageBox with setDetails to display the output though. -- You are receiving this mail because: You are watching all bug changes.
[kdenetwork-filesharing] [Bug 334618] Samba sharing errors are not displayed in the UI
https://bugs.kde.org/show_bug.cgi?id=334618 Nate Graham changed: What|Removed |Added Assignee|unassigned-b...@kde.org |n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kdenetwork-filesharing] [Bug 334618] Samba sharing errors are not displayed in the UI
https://bugs.kde.org/show_bug.cgi?id=334618 Nate Graham changed: What|Removed |Added Component|general |general Assignee|fa...@kde.org |unassigned-b...@kde.org Product|frameworks-kio |kdenetwork-filesharing Version|5.45.0 |unspecified -- You are receiving this mail because: You are watching all bug changes.
