[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 Julius Künzel changed: What|Removed |Added CC||jk.kde...@smartlab.uber.spa ||ce Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #5 from Julius Künzel --- Seems to be fixed with https://invent.kde.org/multimedia/kdenlive/-/merge_requests/29 (???) -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 --- Comment #4 from Christophe Giboudeaux --- Sorry, I didn't notice the typo in Luca's MR. https://invent.kde.org/kde/kdenlive/merge_requests/31 fixes the issue. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 Antonio Rojas changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 Antonio Rojas changed: What|Removed |Added Version Fixed In||19.04.0 Latest Commit||b48d76d898419ed36c8bdb16253 ||f1f0c6c53d210 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 Christophe Giboudeaux changed: What|Removed |Added CC||christo...@krop.fr -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805
--- Comment #3 from Christophe Giboudeaux ---
> From your side, would switching to dynamic linking be sufficient?
For linux distributions, yes, for Windows you would get the opposite issue, I
guess.
something like that should address the problem:
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 4d196d18e..b68f31c2c 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -139,8 +139,12 @@ target_link_libraries(kdenliveLib
${MLTPP_LIBRARIES}
${CMAKE_DL_LIBS}
${CMAKE_THREAD_LIBS_INIT}
-kiss_fft
-RTTR::Core_Lib)
+kiss_fft)
+if(TARGET RTTR::Core)
+target_link_libraries(kdenliveLib RTTR::Core)
+else()
+target_link_libraries(kdenliveLib RTTR::Core_Lib)
+endif()
if(BUILD_COVERAGE)
target_link_libraries(kdenliveLib gcov)
--
You are receiving this mail because:
You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 andreas.sturmlech...@gmail.com changed: What|Removed |Added CC||andreas.sturmlechner@gmail. ||com -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 emohr changed: What|Removed |Added Flags||Brainstorm+ CC||fritzib...@gmx.net -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 --- Comment #2 from Antonio Rojas --- (In reply to Vincent PINON from comment #1) > From RTTR 0.9.6 CMakeFiles, it appeared that Core_lib target is for static > lib, while Core is for dynamic lib. Did you configure rttr to generate > static lib too? No, it's our distro policy not to ship static libraries > It is true that our RTTR integration is for now not yet very > packaging-friendly, we are OK to improve the situation... > From your side, would switching to dynamic linking be sufficient? Not sure what you mean here... switching what to dynamic linking? -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 405805] kdenlive fails to build with external rttr
https://bugs.kde.org/show_bug.cgi?id=405805 Vincent PINON changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from Vincent PINON --- >From RTTR 0.9.6 CMakeFiles, it appeared that Core_lib target is for static lib, while Core is for dynamic lib. Did you configure rttr to generate static lib too? It is true that our RTTR integration is for now not yet very packaging-friendly, we are OK to improve the situation... >From your side, would switching to dynamic linking be sufficient? -- You are receiving this mail because: You are watching all bug changes.
