[kdenlive] [Bug 456296] PVS-Studio issues

2023-10-07 Thread Marius P
https://bugs.kde.org/show_bug.cgi?id=456296

--- Comment #4 from Marius P  ---
Please close this ticket. Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 456296] PVS-Studio issues

2022-07-05 Thread Julius Künzel
https://bugs.kde.org/show_bug.cgi?id=456296

Julius Künzel  changed:

   What|Removed |Added

 CC||jk.kde...@smartlab.uber.spa
   ||ce

--- Comment #3 from Julius Künzel  ---
Thanks! Can you please add the file as attachment? This makes it easier to
download it and also (for future reports) it keeps the conversation cleaner.

BTW it is not wrong that you opened the report here, but it is also fine (and
more common in the team) for this kind of dev tasks to open a GitLab issue on
https://invent.kde.org/multimedia/kdenlive

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 456296] PVS-Studio issues

2022-07-05 Thread Marius P
https://bugs.kde.org/show_bug.cgi?id=456296

--- Comment #2 from Marius P  ---
13a46c5515063024b2bb184e9e6921d6d4c21121

pvs-studio.com/en/docs/warnings/1   err Help: The documentation
for all analyzer warnings is available here:
https://pvs-studio.com/en/docs/warnings/.
/home/n/kde/src/multimedia/kdenlive/src/utils/gentime.h 93  err V616
The '(Q_COMPLEX_TYPE)' named constant with the value of 0 is used in the
bitwise operation.
/home/n/kde/src/multimedia/kdenlive/renderer/renderjob.cpp  30  err
V730 Not all members of a class are initialized inside the constructor.
Consider inspecting: m_subsProcess.
/home/n/kde/src/multimedia/kdenlive/src/assets/keyframes/model/keyframemodel.cpp
   21  warnV1077 The 'KeyframeModel' constructor contains
potentially uninitialized members. Inspect the following: m_paramType.
/home/n/kde/src/multimedia/kdenlive/src/assets/abstractassetsrepository.hpp
51  warnV730 Not all members of a class are initialized inside the
compiler generated constructor. Consider inspecting: type.
/home/n/kde/src/multimedia/kdenlive/src/assets/assetlist/view/qmltypes/asseticonprovider.cpp
   68  warnV547 Expression 'isGroup' is always false.
/home/n/kde/src/multimedia/kdenlive/src/assets/model/assetparametermodel.cpp   
161 warnV1037 Two or more case-branches perform the same actions. Check
lines: 161, 169, 174
/home/n/kde/src/multimedia/kdenlive/src/assets/model/assetparametermodel.cpp   
743 warnV612 An unconditional 'break' within a loop.
/home/n/kde/src/multimedia/kdenlive/src/assets/model/assetparametermodel.cpp   
759 warnV636 The 'frameSize.width() / frameSize.height()' expression
was implicitly cast from 'int' type to 'double' type. Consider utilizing an
explicit type cast to avoid the loss of a fractional part. An example: double A
= (double)(X) / Y;.
/home/n/kde/src/multimedia/kdenlive/src/jobs/filtertask.h   17  warn   
V690 The 'Consumer' class implements a copy constructor, but lacks the copy
assignment operator. It is dangerous to use such a class.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/curves/abstractcurvewidget.ipp
 12  err V730 Not all members of a class are initialized inside the
constructor. Consider inspecting: m_wWidth, m_wHeight.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/lumaliftgainparam.cpp
  93  err V567 Unspecified behavior. The order of argument
evaluation is not defined for 'setAttribute' function. Consider inspecting the
'Size' variable.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/keyframeimport.cpp 
973 warnV636 The 'kfrData[2].toInt() / 2' expression was implicitly
cast from 'int' type to 'double' type. Consider utilizing an explicit type cast
to avoid the loss of a fractional part. An example: double A = (double)(X) /
Y;.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/keyframeimport.cpp 
981 warnV636 The 'kfrData[3].toInt() / 2' expression was implicitly
cast from 'int' type to 'double' type. Consider utilizing an explicit type cast
to avoid the loss of a fractional part. An example: double A = (double)(X) /
Y;.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/keyframeimport.cpp 
985 warnV636 The 'kfrData[2].toInt() / 2' expression was implicitly
cast from 'int' type to 'double' type. Consider utilizing an explicit type cast
to avoid the loss of a fractional part. An example: double A = (double)(X) /
Y;.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/keyframeimport.cpp 
986 warnV636 The 'kfrData[3].toInt() / 2' expression was implicitly
cast from 'int' type to 'double' type. Consider utilizing an explicit type cast
to avoid the loss of a fractional part. An example: double A = (double)(X) /
Y;.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/keyframeimport.cpp 
991 warnV636 The 'kfrData[3].toInt() / 2' expression was implicitly
cast from 'int' type to 'double' type. Consider utilizing an explicit type cast
to avoid the loss of a fractional part. An example: double A = (double)(X) /
Y;.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/keyframeimport.cpp 
999 warnV636 The 'kfrData[2].toInt() / 2' expression was implicitly
cast from 'int' type to 'double' type. Consider utilizing an explicit type cast
to avoid the loss of a fractional part. An example: double A = (double)(X) /
Y;.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/keyframeimport.cpp 
1220warnV636 The 'kfrData[2].toInt() / 2' expression was implicitly
cast from 'int' type to 'double' type. Consider utilizing an explicit type cast
to avoid the loss of a fractional part. An example: double A = (double)(X) /
Y;.
/home/n/kde/src/multimedia/kdenlive/src/assets/view/widgets/keyframeimport.cpp 
1228warnV636 The 'kfrData[3].toInt() / 2' expression was implicitly
cast from 'int' type to 'double' type. 

[kdenlive] [Bug 456296] PVS-Studio issues

2022-07-04 Thread Eric Jiang
https://bugs.kde.org/show_bug.cgi?id=456296

Eric Jiang  changed:

   What|Removed |Added

 CC||erji...@alumni.iu.edu

--- Comment #1 from Eric Jiang  ---
Hi Marius,
Can you also post the git commit hash of the commit that you analyzed?  Some of
the line numbers have changed since you ran your analysis so knowing which
commit you used would help identify the right line.

-- 
You are receiving this mail because:
You are watching all bug changes.